Skip to content

Ritchie Martori
ritch

  • Fremont, California
  • Joined on

Organizations

@deployd @strongloop @expressjs
ritch commented on pull request strongloop/express#2880
@ritch

@tunniclm can you split these changes out into separate commits to be consistent with these sorts of changes in the past? https://github.com/tunnic…

ritch commented on pull request strongloop/loopback-workspace#248
@ritch

LGTM

ritch commented on pull request strongloop/strong-remoting#279
@ritch

LGTM

ritch commented on pull request strongloop/strong-remoting#279
@ritch

Deprecate invokeMethodInContext(ctx, method, cb) in favour of simpler invokeMethodInContext(ctx, cb). :+1:

ritch commented on issue nodejs/node#4953
@ritch

I would like to be involved and would recommend a few others. @hacksparrow @tunniclm @bajtos @jeffbcross @raymondfeng

@ritch
is express dying?
ritch commented on issue strongloop/express#2844
ritch commented on pull request strongloop/loopback-phase#10
@ritch

LGTM

ritch commented on pull request strongloop/strong-remoting#278
@ritch

LGTM... meant to do this quite a while ago. :+1:

ritch commented on pull request strongloop/loopback#1989
@ritch

Made a few comments. LGTM either way. Feel free to merge as is.

ritch commented on pull request strongloop/loopback#1989
@ritch

Same comment as above: perhaps throw here?

ritch commented on pull request strongloop/loopback#1989
@ritch

Maybe we should deprecate this instead of removing it... to make it easier to catch?

ritch commented on pull request strongloop/loopback#1989
@ritch

I think we should assert or throw... How would the app function with this setting?

ritch commented on issue strongloop/express#2853
@ritch

@dougwilson you are the only one that can release at the moment. Can you add @hacksparrow (his npm username is "hacksparrow") to the npm package so…

ritch commented on issue strongloop/express#2844
@ritch

I did not voluntarily give up on Express, IBM forced me out. @dougwilson - IBM has no intention of forcing anyone off the project. Especially som…

ritch commented on issue strongloop/express#2844
@ritch

You could take a look at the list of help wanted issues if you are looking for some issues to dig into. The project needs the most help right now t…

ritch commented on issue strongloop/express#2844
@ritch

Hey gals and guys. Express is certainly active and poised to move even faster. I agree with concerns that @dougwilson has been unfairly carrying th…

@ritch
@ritch
@ritch
  • @ritch eb90d1c
    Remove old rest-models example
ritch commented on pull request strongloop/strong-remoting#272
@ritch

this could be input = '"' + input + '"'; couldn't it?

ritch commented on pull request strongloop/strong-remoting#272
@ritch

use typeof input not typeof(input)

ritch commented on pull request strongloop/strong-remoting#272
@ritch

To address this strongloop-internal/scrum-cs#396 I don't think this exactly addresses the issue, but it might be a welcome feature.

ritch commented on issue strongloop/express#2844
@ritch

What? Doug Wilson is doing a spectacular job of maintenance. One of the hardest working folks I've ever encountered in open source. +1

ritch commented on pull request strongloop/loopback-sdk-angular-cli#36
@ritch

LGTM... make sure any references are removed from confluence

ritch commented on pull request strongloop/loopback#1894
@ritch

LGTM

ritch commented on pull request strongloop/loopback#1860
@ritch

Not a fan of console.warn over debug... Otherwise LGTM

ritch commented on pull request strongloop/loopback-workspace#237
@ritch

LGTM

@ritch

Another option is to optionally depend on mongodb (or similar, eg. an ObjectID module). Sort of like this: ```js try { mongodb = require('mongodb');

Something went wrong with that request. Please try again.