Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Conversation

@Azbury
Copy link
Contributor

@Azbury Azbury commented May 24, 2022

#761

Remove pui- prefix

@Azbury Azbury requested review from mrtrimble and tedk13 May 24, 2022 15:58
Copy link
Contributor

@mrtrimble mrtrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make Platform UI a little leaner, nice!!

Copy link
Contributor

@tedk13 tedk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like but, I think we could remove the need for the mixins. The benefit of those was to be able to create both classes.

@Azbury
Copy link
Contributor Author

Azbury commented May 24, 2022

Would that just be removing the lines like

and replacing with just the class name instead?

@tedk13
Copy link
Contributor

tedk13 commented May 24, 2022

Yes.

@tedk13
Copy link
Contributor

tedk13 commented May 24, 2022

So accordion.scss:
@mixin accordion {
just becomes
.accordion {

@mrtrimble mrtrimble merged commit 4f67c32 into ritterim:master May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants