Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple save folders #26

Closed
morsanu opened this issue Nov 16, 2017 · 8 comments
Closed

Multiple save folders #26

morsanu opened this issue Nov 16, 2017 · 8 comments

Comments

@morsanu
Copy link

@morsanu morsanu commented Nov 16, 2017

I ran into a small problem, I have more than one sass folders in my solution, something like this:

root
---- sass
---- ---- style.scss
---- folder1
---- ---- sass
---- ---- ---- style.scss

I would like to save my css files like this:

root
---- sass
---- ---- style.scss
---- css
---- ---- style.css
---- folder1
---- ---- sass
---- ---- ---- style.scss
---- ---- css
---- ---- ---- style.css

but the "savePath" setting is global and it's relative to the root.
Is there a way to achieve what I'm looking for?

@ritwickdey

This comment has been minimized.

Copy link
Owner

@ritwickdey ritwickdey commented Nov 18, 2017

yes! In your example, it will not work!
I'm wondering how the setting will be look like! Have you any suggestion?

I think, it might be good:

savePath : ~/../css/

this ~ will be indicates the individual Sass/Scss path

@boyum

This comment has been minimized.

Copy link
Contributor

@boyum boyum commented Nov 18, 2017

Perhaps the includeItems array could be configured to take objects as well. Maybe something like this could work:

"includeItems": [
 {
    "input": "./scss/src.scss",
    "output": "./css/dist.css"
  }
]

Another way would be to do it like webpack.

@morsanu

This comment has been minimized.

Copy link
Author

@morsanu morsanu commented Nov 19, 2017

@ritwickdey I was thinking of the same solution. "~" to work as a relative root to the specific scss/sass folder.

@hkarn

This comment has been minimized.

Copy link

@hkarn hkarn commented Nov 29, 2017

That the css save path can't be set relative to the scss file location just became my main issue when switchin from Atom to VS Code working on my old projects.

Save path savePath : ~/../css/ for relative to .scss would be very good.

@boyum

This comment has been minimized.

Copy link
Contributor

@boyum boyum commented Dec 13, 2017

Just adding support for relative path might solve a few problems, but considering scenarios like #29 and #32, entirely independent filenames could be necessary. To combine them might be an idea, like this:

"includeItems": [
 {
    "input": "~/scss/src.scss",
    "output": "~/css/dist.css"
  }
]

I haven't looked at the code for this in a while, so it might be difficult to solve the problem like this.

@ritwickdey

This comment has been minimized.

Copy link
Owner

@ritwickdey ritwickdey commented Dec 17, 2017

Hi @boyum... It would be nice... but there is also a savePath settings.
But don't think it's making extra complexity ?

@ritwickdey ritwickdey self-assigned this Dec 21, 2017
ritwickdey added a commit that referenced this issue Dec 21, 2017
ritwickdey added a commit that referenced this issue Dec 21, 2017
@ritwickdey

This comment has been minimized.

Copy link
Owner

@ritwickdey ritwickdey commented Dec 21, 2017

This feature is added in v1.2.0 update. Please update it from vscode marketplace 😄.

Let me know if it okay or not. 😄

If you like the extension, please drop a review to vscode marketplace. 😸

@ritwickdey

This comment has been minimized.

Copy link
Owner

@ritwickdey ritwickdey commented Dec 21, 2017

All the further discussion of "compiling SCSS to CSS with different name" will be #29.

For now, I'm closing this issue as the main purpose of the issue is added from v1.2.0

@ritwickdey ritwickdey closed this Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.