From 292edfde3d9366b8676f2b2a5a31468a27ad6ec2 Mon Sep 17 00:00:00 2001 From: luigi-rosso Date: Sat, 9 Mar 2024 21:47:26 +0000 Subject: [PATCH] Always decode 3 or 4 channel PNG images. The bug @HayesGordon ran into with Unity was because we were trying to decode grayscale images to a single-channel image and then expanding those to 4 channels as the Rive Renderer expects RGBA. That was padding missing channel data with 255, which is why we were getting Cyan (R would be read, GBA were filled with 255). Instead, we make the Bitmap library only work with RGB and RGBA and we let libpng do the expansion for us. Glorious: CleanShot 2024-03-08 at 21 28 21@2x Diffs= 09feaccb0 Always decode 3 or 4 channel PNG images. (#6818) --- .rive_head | 2 +- .rive_renderer | 2 +- submodules/rive-cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.rive_head b/.rive_head index 534137d..9f56a91 100644 --- a/.rive_head +++ b/.rive_head @@ -1 +1 @@ -7cb7eb8122d3625aad2c6032615006cc8f5383e8 +09feaccb0c5bb3a2f88c23aca6c669d79eee4428 diff --git a/.rive_renderer b/.rive_renderer index ec6bc38..591e914 100644 --- a/.rive_renderer +++ b/.rive_renderer @@ -1 +1 @@ -835e7169f9a219b4d69e960f1b93fe2a4d8c3e84 +114fbe972484aa69c1f8f2796fc3e811d3c9a2c8 diff --git a/submodules/rive-cpp b/submodules/rive-cpp index ce2c740..033a452 160000 --- a/submodules/rive-cpp +++ b/submodules/rive-cpp @@ -1 +1 @@ -Subproject commit ce2c740e930d14e745d1828599a4f16efacccf61 +Subproject commit 033a45243cb2656c5fd57a845fd6689b550263d9