Ernesto Rivera rivera-ernesto

Organizations

@CyberAgent @taptaptap @ameba-proteus @PTEz @latenitesoft @CocoaLumberjack @PRTween @SLF4C
@rivera-ernesto
@rivera-ernesto
Use an absolute path to identify the modulemap.
1 commit with 2 additions and 2 deletions
@rivera-ernesto

Yes, they are nor related. Unit Tests are broken because of a race condition.

@rivera-ernesto
@rivera-ernesto
Change code samples to use DDLogFlagWarning
1 commit with 16 additions and 16 deletions
@rivera-ernesto

Thanks!

@rivera-ernesto
@rivera-ernesto
Prevent duplicate log entries when both DDASLLogCapture and DDASLLogger are used
1 commit with 15 additions and 1 deletion
@rivera-ernesto

Ok, merging this. Please give it a good try. We will need some cleanup and fix unit tests before making a new release.

@rivera-ernesto

Still marked as conflicting below.

@rivera-ernesto
@rivera-ernesto
Remove execute permission on non-executable files
1 commit with 0 additions and 0 deletions
@rivera-ernesto

Most documentation hasn't been updated since 1.9.x.

@rivera-ernesto

I see. Then probably we need to add that to the README.

@rivera-ernesto

I would like to but I was waiting for an answer from the contributor. If you want you can contribute to that pull request too so we can merge it.

@rivera-ernesto

Could you please rebase this? We just merged ASL capture code from #512 that may be conflicting.

@rivera-ernesto

If you want @guidomb you can fork @mackross, fix the conflicts and make another pull request that we can merge.

@rivera-ernesto
@rivera-ernesto
Several fixes/tweaks to DDASLLogCapture.
1 commit with 14 additions and 16 deletions
@rivera-ernesto

The race condition making some tests fail occurred on master after @rivera-ernesto merged #514. https://travis-ci.org/CocoaLumberjack/CocoaLumberj…

@rivera-ernesto

I still think this is weird. Why this commit would change the execution order this way? Just merged #514, which as master, doesn't have this execut…

@rivera-ernesto
Converted machThreadID instead of threadID
@rivera-ernesto
@rivera-ernesto
Fix NSLog threadid mismatch with iOS 8+/OSX 10.10+
2 commits with 33 additions and 2 deletions
@rivera-ernesto

Looks, good. Thanks!

@rivera-ernesto

I run Travis in master to be sure, and it passed. Which is weird. The thing is if we break Travis we can't safely merge subsequent pull requests.

@rivera-ernesto

Check where you define ddLogLevel. Sounds like there are two conflicting definitions.

@rivera-ernesto
XcodeColors doesn't work
@rivera-ernesto

I think we do have a few file logger remaining bugs. It is better to use one of the existing issues (and reopen them if needed), instead of opening…

@rivera-ernesto

Looks great except for the Travis maybe unrelated error here.