Skip to content

Ernesto Rivera
rivera-ernesto

Organizations

@CyberAgent @taptaptap @ameba-proteus @PTEz @latenitesoft @CocoaLumberjack @PRTween @SLF4C
@rivera-ernesto

#53 does sound similar. Should we keep the discussion there?

@rivera-ernesto

Nice!

@rivera-ernesto

Please make sure this happen on non-Debug builds.

@rivera-ernesto

Check #682.

@rivera-ernesto

I think you should only send log messages without caring (or imposing) a particular log output to users. Especially if it's a TTY output (log files…

@rivera-ernesto

I don't think you should need two TTY Loggers as I don't see what important distinction would there be between then as they only output to the cons…

@rivera-ernesto
@rivera-ernesto
Update license year
1 commit with 30 additions and 30 deletions
@rivera-ernesto

Just check the Demo app in this repository. It has two consoles, one of them is an embedded one.

@rivera-ernesto

I think it is yet to be done and added to the repository ;)

@rivera-ernesto

Release mode is the important one. Debug builds are not optimized for memory or performance, just for build speed and debug ease.

@rivera-ernesto
@rivera-ernesto
Added check to prevent duplicate loggers.
1 commit with 8 additions and 0 deletions
@rivera-ernesto

Yes, but to understand why you need to profile it and check where its retain count gets incremented.

@rivera-ernesto

I had a similar problem where some color combinations are not picked up by Xcode's console. Could you try some color variations?

@rivera-ernesto
@rivera-ernesto
Clean up CocoaLumberjack.swift a little
1 commit with 28 additions and 17 deletions
@rivera-ernesto

Thanks, looking good.

@rivera-ernesto

I think it was already working. What is needed is some more testing and then the hardest part, make frameworks adopt it.

@rivera-ernesto

No way to know for sure unless we profile one of your test projects with Instruments.

@rivera-ernesto

Sorry @kballard, seems like nobody reviewed this. Could you update the pull request?

@rivera-ernesto
@rivera-ernesto
DDLog usable via instances
2 commits with 338 additions and 70 deletions
@rivera-ernesto

Mmm, Maybe we can use a variable now to fix that?

@rivera-ernesto

Check how it was fixed once in #2.

@rivera-ernesto

The Cocoapods' generated file may have changed its path, name or format.

rivera-ernesto deleted branch modernize_code at PTEz/EasyTableView
rivera-ernesto deleted branch 2.0 at PTEz/EasyTableView
@rivera-ernesto

Sadly I am not actively using the library but it would be great to have a pull request to fix that.

Something went wrong with that request. Please try again.