Ernesto Rivera rivera-ernesto

Organizations

@CyberAgent @taptaptap @ameba-proteus @PTEz @latenitesoft @CocoaLumberjack @PRTween @SLF4C
@rivera-ernesto

Please feel free to propose your solution in a pull request.

@rivera-ernesto

Erros in NSObject.h and other Foundation files look like a serious errors unrelated to CocoaLumberjack.

@rivera-ernesto

As it was a x.x.1 minor version update, we should keep 2.0.0 behavior.

@rivera-ernesto

Probably a duplicate of #33 and #81.

@rivera-ernesto

Well that commit is only good practices, so it may be better to check the preprocessor #if checks.

@rivera-ernesto

Hopefully someone can figure this out and make a pull request as at the moment I am not using the library.

@rivera-ernesto
Small fixes
2 commits with 48 additions and 5 deletions
@rivera-ernesto
  • @MaddTheSane 0f00618
    Merge remote-tracking branch 'CocoaLumberjack/swift_support' into swi…
  • @MaddTheSane 63fde14
    Add an umbrella header for CocoaLumberjackSwift. To make everyone happy.
  • 21 more commits »
@rivera-ernesto
Swift 1.2 fixes
22 commits with 107 additions and 112 deletions
@rivera-ernesto

Right. It's 8.1...

@rivera-ernesto
@rivera-ernesto
Swift 2 fixes
44 commits with 482 additions and 151 deletions
@rivera-ernesto

Yup. Let's merge this as it targets a non master branch. When Xcode 7 is out we can merge it back to master.

@rivera-ernesto

Travis errors here I think are only due to Travis not supporting Swift 2.0 yet right?

@rivera-ernesto

I don't think he gets any mentions' notification. We should try contacting him directly but I can't find a valid email address.

@rivera-ernesto

Ideally libraries shouldn't require a given version, or even require a given log framework bu simply a façade such as SLF4C/SLF4C#1.

@rivera-ernesto

Storing logs in an App Group's shared folder could be one way to make those logs accessible from the main app maybe?

@rivera-ernesto
@rivera-ernesto
Add armv7s to static library
1 commit with 8 additions and 0 deletions
@rivera-ernesto

I see. Weird decision from Apple. As you say including more slices in a library has nothing wrong at all.

@rivera-ernesto

Then why isn't armv7s part of ARCHS_STANDARD? I would prefer to keep default values as much as possible.

@rivera-ernesto
Can't use @import Cocoalumberjack
@rivera-ernesto

Duplicate of #405 (comment).

@rivera-ernesto

Is this something that will get added by default with Xcode 7? If so you better switch to our swift_2.0 branch instead.

@rivera-ernesto

Yes, probably switching back is better. For instance standard Objective-C setters don't use self-> neither and would be hard to keep consistency wi…

@rivera-ernesto

Memory leak fixes look good, but not sure about how self-> annotations are needed or could impact performance. We had some discussions about using …