From 945b5bbd244394c33484578d6b3520fbaec76230 Mon Sep 17 00:00:00 2001 From: MasterPtato <23087326+MasterPtato@users.noreply.github.com> Date: Tue, 27 Aug 2024 18:57:47 +0000 Subject: [PATCH] fix(ds): disable retries for nomad monitors (#1091) Fixes RVTEE-552 ## Changes --- svc/pkg/ds/src/workers/nomad_monitor_alloc_plan.rs | 8 ++------ svc/pkg/ds/src/workers/nomad_monitor_alloc_update.rs | 8 ++------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/svc/pkg/ds/src/workers/nomad_monitor_alloc_plan.rs b/svc/pkg/ds/src/workers/nomad_monitor_alloc_plan.rs index 8e719e76cc..8a2cb464b4 100644 --- a/svc/pkg/ds/src/workers/nomad_monitor_alloc_plan.rs +++ b/svc/pkg/ds/src/workers/nomad_monitor_alloc_plan.rs @@ -121,12 +121,8 @@ async fn worker( // Check if run found let Some(DbOutput { server_id }) = db_output else { - if ctx.req_dt() > util::duration::minutes(5) { - tracing::error!("discarding stale message"); - return Ok(()); - } else { - retry_bail!("run not found, may be race condition with insertion"); - } + tracing::error!("run not found, may be race condition with insertion"); + return Ok(()); }; tracing::info!(%job_id, %server_id, "updated run"); diff --git a/svc/pkg/ds/src/workers/nomad_monitor_alloc_update.rs b/svc/pkg/ds/src/workers/nomad_monitor_alloc_update.rs index a7228f3aaf..58b8882c34 100644 --- a/svc/pkg/ds/src/workers/nomad_monitor_alloc_update.rs +++ b/svc/pkg/ds/src/workers/nomad_monitor_alloc_update.rs @@ -195,12 +195,8 @@ async fn worker( .await?; let Some((run_id, finish_ts)) = run_row else { - if ctx.req_dt() > util::duration::minutes(5) { - tracing::error!("discarding stale message"); - return Ok(()); - } else { - retry_bail!("run not found, may be race condition with insertion"); - } + tracing::error!("run not found, may be race condition with insertion"); + return Ok(()); }; crate::workers::webhook::call(ctx, alloc_id.to_string()).await?;