-
Notifications
You must be signed in to change notification settings - Fork 131
chore(site): how we built vercle functions blog #3228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(site): how we built vercle functions blog #3228
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
commit: |
PR Review: Blog Post - WebSocket Servers for Vercel FunctionsOverviewThis PR adds a comprehensive technical blog post explaining how Rivet enables WebSocket servers on Vercel Functions using tunneling. The content is well-written, technically accurate, and provides excellent educational value. ✅ StrengthsContent Quality
Technical Accuracy
🔍 Issues & Recommendations1. Typo in PR Title (Critical)The PR title says "vercle" instead of "vercel" Action: Update the PR title 2. WebSocket Cleanup Missing (Medium Priority)Lines 131-152: The WebSocket connection is never closed when the component unmounts. Consider adding cleanup logic to close the WebSocket in the useEffect return function. 3. Missing Error Handling (Medium Priority)Lines 132-151, 227-229: Code examples lack error handling for WebSocket connection failures, JSON parse errors, and network timeouts. Consider adding try-catch blocks or comments indicating error handling should be added in production. 4. TypeScript Type Safety (Low Priority)Lines 125, 220: Messages state is initialized as empty array without type annotation. Consider adding explicit types for better TypeScript safety. 📝 Version BumpThe version bump from 25.8.0 to 25.8.1 across all packages in Cargo.lock and openapi.json looks correct and follows semantic versioning conventions for a content-only release. 🎯 SummaryOverall Assessment: Excellent blog post with minor issues Required Changes:
Recommended Changes:
🚀 Great Work!This is a high-quality technical blog post that:
The issues identified are relatively minor and mostly focused on making the code examples more production-ready. The core content is solid and ready to publish with minimal changes. Approval Status: ✅ Approved with minor recommendations Review generated by Claude Code |

No description provided.