fix: bring back controls to stepper

[jog1t]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-inspector	Ready	Preview	Comment	Dec 5, 2025 11:52am

3 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Ignored			Dec 5, 2025 11:52am
rivet-site	Ignored	Preview		Dec 5, 2025 11:52am
rivetkit-serverless	Skipped			Dec 5, 2025 11:52am

[jog1t]

• fix: bring back controls to stepper #3595 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Merge activity

• Dec 5, 11:49 AM UTC: jog1t added this pull request to the Graphite merge queue.
• Dec 5, 11:50 AM UTC: CI is running for this pull request on a draft pull request (#3596) due to your merge queue CI optimization settings.
• Dec 5, 11:51 AM UTC: Merged by the Graphite merge queue via draft PR: #3596.

[graphite-app]

Graphite Automations

"Test" took an action on this PR • (12/05/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

[claude]

Pull Request Review

Summary

This PR changes the default value of showControls parameter in the StepPanel component from false to true, restoring the stepper controls (Previous/Next buttons) in the default case.

Analysis

Change Location: frontend/src/app/forms/stepper-form.tsx:155

Code Quality: ✅ Good

• The change is minimal and focused
• The fix correctly addresses the issue of missing controls
• The code follows existing patterns in the file

Behavioral Impact: ⚠️ Consider

The change affects two different rendering paths:

1. Normal stepper mode (line 130-139): Uses StepPanel without explicitly passing showControls, so it now defaults to true ✅
2. showAllSteps mode (line 119-128): Explicitly passes showControls={steps.length - 1 === index}, so behavior is unchanged ✅

The change appears intentional and correct - in normal mode, controls should be shown by default to allow navigation.

Potential Concerns

Minor - Consistency Check:

• When showAllSteps={true}, controls only appear on the last step (steps.length - 1 === index)
• When showAllSteps={false} (normal mode), controls now appear on every step
• This seems intentional, but worth confirming this is the desired UX

Question: In normal stepper mode (line 137), the component doesn't pass showPrevious prop, so it defaults to undefined. Looking at line 169, the Previous button only renders when showPrevious is truthy. This means:

• In normal mode: Only "Next" button appears (no Previous button)
• In showAllSteps mode: showPrevious={false} is explicitly passed (also no Previous button)

Is this the intended behavior, or should normal mode also allow going back to previous steps?

Security: ✅ No concerns

No security implications from this change.

Performance: ✅ No concerns

No performance impact.

Testing: ℹ️ Recommendation

Consider testing:

1. Normal stepper flow - verify controls appear and navigation works
2. showAllSteps mode - verify only the last step shows controls
3. Multi-step forms in all the affected dialog files:
   • connect-railway-frame.tsx
   • connect-vercel-frame.tsx
   • connect-manual-serverfull-frame.tsx
   • connect-manual-serverless-frame.tsx
   • connect-quick-railway-frame.tsx
   • connect-quick-vercel-frame.tsx

Verdict: ✅ Approve with minor question

The change is straightforward and appears correct. The only question is whether the lack of a "Previous" button in normal stepper mode is intentional or if that's another issue to address separately.

---

Review generated by Claude Code