-
Notifications
You must be signed in to change notification settings - Fork 136
feat(site): auto-generate templates from examples dir #3603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11-30-feat_site_add_templates
Are you sure you want to change the base?
feat(site): auto-generate templates from examples dir #3603
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
More templates
@rivetkit/cloudflare-workers
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
@rivetkit/engine-runner
@rivetkit/engine-runner-protocol
commit: |
Pull Request Review: Auto-generate templates from examples directorySummaryThis PR automates the generation of template metadata from the examples directory, introducing validation, screenshot generation, and improved consistency. The changes reorganize the build system into a modular structure. ✅ Strengths
🐛 Potential Issues1. Resource Cleanup in Screenshot Generation (screenshots.ts:114-124)The process cleanup logic has a potential race condition:
Recommendation: Wait for actual process exit event instead of relying on fixed delays. 2. Port Conflicts (screenshots.ts:55, 64-67)The code assumes
Recommendation: Consider using dynamic port allocation or ensuring each example uses a unique port. 3. Hardcoded Wait Times (screenshots.ts:9, 87, 104)Total wait time is 5+ seconds per screenshot with hardcoded delays. Complex apps may need more time; simple apps waste time. Recommendation: Use more intelligent waiting strategies like custom "ready" markers in examples. 4. Memory Leak Risk (screenshots.ts:70-71)Event listeners on Recommendation: Remove event listeners in the finally block.
|

No description provided.