Skip to content

chore: phase 0 prereqs (rivetkit workspace member, serde_bare align, wasm skip.agentOs default)#5188

Open
abcxff wants to merge 1 commit into
stack/docs-plan2-todolist-rivetkit_rust_fix-clean-slate-post-wipe-yqrwozvnfrom
stack/chore-phase-0-prereqs-rivetkit-workspace-member-serde_bare-align-wasm-skip-agentos-default-qvnkvkxw
Open

chore: phase 0 prereqs (rivetkit workspace member, serde_bare align, wasm skip.agentOs default)#5188
abcxff wants to merge 1 commit into
stack/docs-plan2-todolist-rivetkit_rust_fix-clean-slate-post-wipe-yqrwozvnfrom
stack/chore-phase-0-prereqs-rivetkit-workspace-member-serde_bare-align-wasm-skip-agentos-default-qvnkvkxw

Conversation

@abcxff

@abcxff abcxff commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@abcxff

abcxff commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Stack for rivet-dev/rivet

Check out this stack: forklift get https://github.com/rivet-dev/rivet/pull/5188
Pull/update this stack: forklift sync
Publish local edits: forklift submit
Merge when ready: forklift merge

@claude

claude Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

PR Review: chore: phase 0 prereqs

Overview

This small prereqs PR does three things:

  1. Adds rivetkit-rust/packages/rivetkit to the Cargo workspace
  2. Aligns serde_bare in the client crate to use the workspace version instead of a pinned one
  3. Defaults agentOs: true in the wasm driver test skip config to prevent failures from native-only agent-os dependencies

Issues

serde_cbor is unmaintained and conflicts with the rest of the codebase

rivetkit-client/Cargo.toml depends on serde_cbor = "0.11.2", and pulling the package into the workspace now makes this visible in the lockfile. Two concerns:

  • serde_cbor is officially unmaintained. The ecosystem successor is ciborium, which the rivetkit crate itself already depends on (visible in the new lockfile entry). Using both in the same workspace is inconsistent.
  • serde_cbor 0.11.2 transitively pulls in half 1.8.3, creating a second version of half in the build graph alongside the existing half 2.7.1. Duplicate major versions add build time and binary size for no benefit.

The rivetkit-client crate should be migrated to ciborium (or use the workspace ciborium dep) before or alongside bringing it into the workspace.


Nits

Comment style (shared-harness.ts)

The added comment is accurate, but per CLAUDE.md conventions it should use complete, flowing sentences rather than a semicolon-separated two-liner and a parenthetical. Suggested rewrite:

// The agent-os suite requires the NAPI runtime because rivetkit-agent-os
// depends on agent-os-client which uses tokio::process, a native-only API.
// Callers can re-enable the suite by passing `skip: { agentOs: false }`.

Empty PR description — even for a prereq/chore PR, a one-sentence summary of what downstream PRs this unblocks would help reviewers triage the stack quickly.


What looks good

  • serde_bare.workspace = true alignment is the right move and keeps version management centralized.
  • Defaulting agentOs: true in the wasm harness is correct — native-only tests silently failing on wasm is a real footgun.
  • The new rivetkit crate lockfile entry uses ciborium and vbare correctly per the architecture constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant