From 6350c72f939a9f60cf6fc15c796c9553a150b42a Mon Sep 17 00:00:00 2001 From: NathanFlurry Date: Fri, 31 May 2024 21:58:40 +0000 Subject: [PATCH] fix(job-run): fix leaking jobs with wrong param order (#815) ## Changes --- svc/pkg/job-run/worker/src/workers/nomad_monitor_eval_update.rs | 2 +- svc/pkg/job-run/worker/src/workers/stop.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/svc/pkg/job-run/worker/src/workers/nomad_monitor_eval_update.rs b/svc/pkg/job-run/worker/src/workers/nomad_monitor_eval_update.rs index abfd28c2ef..9808a2f4c3 100644 --- a/svc/pkg/job-run/worker/src/workers/nomad_monitor_eval_update.rs +++ b/svc/pkg/job-run/worker/src/workers/nomad_monitor_eval_update.rs @@ -137,10 +137,10 @@ async fn worker( match nomad_client_new::apis::jobs_api::delete_job( &NEW_NOMAD_CONFIG, job_id, - None, Some(®ion.nomad_region), None, None, + None, Some(false), None, ) diff --git a/svc/pkg/job-run/worker/src/workers/stop.rs b/svc/pkg/job-run/worker/src/workers/stop.rs index 49bce08590..5a261b57b0 100644 --- a/svc/pkg/job-run/worker/src/workers/stop.rs +++ b/svc/pkg/job-run/worker/src/workers/stop.rs @@ -74,10 +74,10 @@ async fn worker(ctx: &OperationContext) -> GlobalRe match nomad_client_new::apis::jobs_api::delete_job( &NEW_NOMAD_CONFIG, dispatched_job_id, - None, Some(®ion.nomad_region), None, None, + None, Some(false), // TODO: Maybe change back to true for performance? None, )