Skip to content
This repository was archived by the owner on Oct 22, 2025. It is now read-only.

Conversation

@jog1t
Copy link
Collaborator

@jog1t jog1t commented Mar 29, 2025

Closes ACTR-74

@jog1t jog1t requested a review from NathanFlurry March 29, 2025 16:49
Copy link
Collaborator Author

jog1t commented Mar 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t marked this pull request as ready for review March 29, 2025 16:49
@jog1t jog1t requested a review from Copilot March 29, 2025 16:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the CLI entry by adding a missing shebang and updates the usage message in the CLI output. It also removes two bundled tsup configuration files from the actor-core-cli package, likely to streamline the build process.

  • Add missing shebang to ensure the CLI script is executable.
  • Update CLI usage text to reference "@actor-core/cli" instead of "tsc".
  • Remove two bundled tsup config files from the actor-core-cli package.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/actor-core/src/cli/mod.ts Added shebang and updated the usage message for the CLI.
packages/actor-core-cli/tsup.config.bundled_xdlqkb7qzch.mjs Removed the bundled tsup config file.
packages/actor-core-cli/tsup.config.bundled_w1p5t9p450g.mjs Removed the bundled tsup config file.
Comments suppressed due to low confidence (3)

packages/actor-core/src/cli/mod.ts:55

  • [nitpick] Confirm that the updated CLI reference '@actor-core/cli' is consistent with the overall project's documentation and command naming conventions.
`To get access to the ActorCore CLI, ${colours.fg.red}@actor-core/cli${colours.reset}, from the command line either:\n`

packages/actor-core-cli/tsup.config.bundled_xdlqkb7qzch.mjs:1

  • The complete removal of this bundled tsup configuration file might affect the build process. Please ensure that all deployment scripts and build configurations are updated accordingly.
// tsup.config.ts (file removed)

packages/actor-core-cli/tsup.config.bundled_w1p5t9p450g.mjs:1

  • The removal of this bundled tsup configuration file should be verified to avoid breaking any downstream build steps. Confirm that its deletion is intentional and fully supported by the project's build pipeline.
// tsup.config.ts (file removed)

@linear
Copy link

linear bot commented Mar 29, 2025

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 29, 2025

Open in Stackblitzchat-roomcounter

actor-core

yarn add https://pkg.pr.new/rivet-gg/actor-core@807.tgz

@actor-core/cli

yarn add https://pkg.pr.new/rivet-gg/actor-core/@actor-core/cli@807.tgz

create-actor

yarn add https://pkg.pr.new/rivet-gg/actor-core/create-actor@807.tgz

@actor-core/framework-base

yarn add https://pkg.pr.new/rivet-gg/actor-core/@actor-core/framework-base@807.tgz

@actor-core/react

yarn add https://pkg.pr.new/rivet-gg/actor-core/@actor-core/react@807.tgz

@actor-core/bun

yarn add https://pkg.pr.new/rivet-gg/actor-core/@actor-core/bun@807.tgz

@actor-core/cloudflare-workers

yarn add https://pkg.pr.new/rivet-gg/actor-core/@actor-core/cloudflare-workers@807.tgz

@actor-core/nodejs

yarn add https://pkg.pr.new/rivet-gg/actor-core/@actor-core/nodejs@807.tgz

@actor-core/rivet

yarn add https://pkg.pr.new/rivet-gg/actor-core/@actor-core/rivet@807.tgz

commit: 210a0ef

@graphite-app
Copy link

graphite-app bot commented Mar 29, 2025

Merge activity

  • Mar 29, 5:33 PM EDT: jog1t added this pull request to the Graphite merge queue.
  • Mar 29, 5:33 PM EDT: CI is running for this pull request on a draft pull request (#815) due to your merge queue CI optimization settings.
  • Mar 29, 5:34 PM EDT: A user merged this pull request with the Graphite merge queue via draft PR: #815.

graphite-app bot pushed a commit that referenced this pull request Mar 29, 2025
@graphite-app graphite-app bot closed this Mar 29, 2025
@graphite-app graphite-app bot deleted the 03-29-fix_cli_add_missing_shebang branch March 29, 2025 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants