-
Notifications
You must be signed in to change notification settings - Fork 44
fix(cli): add missing shebang #807
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the CLI entry by adding a missing shebang and updates the usage message in the CLI output. It also removes two bundled tsup configuration files from the actor-core-cli package, likely to streamline the build process.
- Add missing shebang to ensure the CLI script is executable.
- Update CLI usage text to reference "@actor-core/cli" instead of "tsc".
- Remove two bundled tsup config files from the actor-core-cli package.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/actor-core/src/cli/mod.ts | Added shebang and updated the usage message for the CLI. |
| packages/actor-core-cli/tsup.config.bundled_xdlqkb7qzch.mjs | Removed the bundled tsup config file. |
| packages/actor-core-cli/tsup.config.bundled_w1p5t9p450g.mjs | Removed the bundled tsup config file. |
Comments suppressed due to low confidence (3)
packages/actor-core/src/cli/mod.ts:55
- [nitpick] Confirm that the updated CLI reference '@actor-core/cli' is consistent with the overall project's documentation and command naming conventions.
`To get access to the ActorCore CLI, ${colours.fg.red}@actor-core/cli${colours.reset}, from the command line either:\n`
packages/actor-core-cli/tsup.config.bundled_xdlqkb7qzch.mjs:1
- The complete removal of this bundled tsup configuration file might affect the build process. Please ensure that all deployment scripts and build configurations are updated accordingly.
// tsup.config.ts (file removed)
packages/actor-core-cli/tsup.config.bundled_w1p5t9p450g.mjs:1
- The removal of this bundled tsup configuration file should be verified to avoid breaking any downstream build steps. Confirm that its deletion is intentional and fully supported by the project's build pipeline.
// tsup.config.ts (file removed)
|
Open in Stackblitz • chat-room • counter actor-core
@actor-core/cli
create-actor
@actor-core/framework-base
@actor-core/react
@actor-core/bun
@actor-core/cloudflare-workers
@actor-core/nodejs
@actor-core/rivet
commit: |
Merge activity
|

Closes ACTR-74