Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Load New Data Feature #144

merged 5 commits into from Jun 19, 2019


Copy link

hackerde commented Jun 17, 2019

This pull request addresses multiple issues:

resolves #114
resolves #31
resolves #6

It also makes the configure dialog movable without moving the entire visualization window.
The configure dialog and progress dialog are created dynamically and deleted when their use if over.

Anway De added 5 commits Jun 17, 2019
RIVET now closes properly when exited from the dataselectdialog.
Configure dialog can now be moved around without affecting Visualization Window position.
The load new data opens up the dataselectdialog.
If user loads new data and computes it, all data structures are cleared.
Computation thread is restarted.
In visualizationwindow.cpp:
Removed redundant function `reset_window()`.
Included its functionality in `init()`.
Also moved Progress Dialog creation to `init()` instead of constructor.

In slice_diagram.cpp and persistence_diagram.cpp:
Removed redundant parameters in `reset()` function.

Added comments as seemed necessary.
Clang-format seems to have formatted some additional lines.
Probably these lines were not formatted when added.
This is a separate commit because these changes do not affect any code functionality.

This comment has been minimized.

Copy link

mlesnick commented Jun 19, 2019

I've tested this on MacOS X and it looks to work properly. Thank you Anway.

@mlesnick mlesnick merged commit 51356c6 into rivetTDA:master Jun 19, 2019
@hackerde hackerde deleted the hackerde:window branch Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.