New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #211

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@SamWhited
Copy link
Contributor

SamWhited commented Dec 21, 2018

Hello,

Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go.

Because this library is still below version 2 the go.mod file is fairly simple. The only other thing that would need to be done if this PR were merged is to create a semver compatible tag (eg. v0.0.1) that users of this library can pin to.

Thank you for your consideration.

@rivo

This comment has been minimized.

Copy link
Owner

rivo commented Dec 25, 2018

Please see #169 (comment) and the linked issues for more infos.

@rivo rivo closed this Dec 25, 2018

@SamWhited

This comment has been minimized.

Copy link
Contributor Author

SamWhited commented Dec 25, 2018

The release branch has been cut and a beta is out; this will not change before 1.12. Not to mention that it has been merged and released into all supported Go versions. Now is the time we're trying to get adoption up before it becomes the default in 1.12. This has been announced, it is final, it is official. Please reconsider so that we can have our packages that depend on tview ready before the final release of 1.12 is cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment