diff --git a/cypress/integration/2_rules.spec.js b/cypress/integration/2_rules.spec.js index fa667841e..edcb6ab4c 100644 --- a/cypress/integration/2_rules.spec.js +++ b/cypress/integration/2_rules.spec.js @@ -169,6 +169,7 @@ describe('Rules', () => { ); // Enter the reference + cy.contains('Add another URL').click(); cy.get('[data-test-subj="rule_references_field_0"]').type(SAMPLE_RULE.references); // Enter the false positive cases diff --git a/public/pages/CreateDetector/components/ConfigureFieldMapping/containers/ConfigureFieldMapping.tsx b/public/pages/CreateDetector/components/ConfigureFieldMapping/containers/ConfigureFieldMapping.tsx index 9b052b58b..a7b2b5035 100644 --- a/public/pages/CreateDetector/components/ConfigureFieldMapping/containers/ConfigureFieldMapping.tsx +++ b/public/pages/CreateDetector/components/ConfigureFieldMapping/containers/ConfigureFieldMapping.tsx @@ -253,7 +253,7 @@ export default class ConfigureFieldMapping extends Component< - +
{`Automatically mapped fields (${mappedRuleFields.length})`}
@@ -303,7 +303,7 @@ export default class ConfigureFieldMapping extends Component< - +
Pending field mappings
diff --git a/public/pages/CreateDetector/components/DefineDetector/components/DetectionRules/DetectionRules.tsx b/public/pages/CreateDetector/components/DefineDetector/components/DetectionRules/DetectionRules.tsx index 882c8852e..07ab517bd 100644 --- a/public/pages/CreateDetector/components/DefineDetector/components/DetectionRules/DetectionRules.tsx +++ b/public/pages/CreateDetector/components/DefineDetector/components/DetectionRules/DetectionRules.tsx @@ -92,7 +92,7 @@ export const DetectionRules: React.FC = ({ - +

{`Detection rules (${enabledRulesCount} selected)`}

diff --git a/public/pages/Detectors/containers/DetectorDetailsView/DetectorDetailsView.tsx b/public/pages/Detectors/containers/DetectorDetailsView/DetectorDetailsView.tsx index f3e7ea60e..6d6419f7b 100644 --- a/public/pages/Detectors/containers/DetectorDetailsView/DetectorDetailsView.tsx +++ b/public/pages/Detectors/containers/DetectorDetailsView/DetectorDetailsView.tsx @@ -4,6 +4,7 @@ */ import React from 'react'; +import { EuiSpacer } from '@elastic/eui'; import { DetectorBasicDetailsView } from '../../components/DetectorBasicDetailsView/DetectorBasicDetailsView'; import { DetectorRulesView } from '../../components/DetectorRulesView/DetectorRulesView'; import { RuleItem } from '../../../CreateDetector/components/DefineDetector/components/DetectionRules/types/interfaces'; @@ -68,7 +69,12 @@ export class DetectorDetailsView extends React.Component< {rulesCanFold ? detectorRules : null} - {rulesCanFold ? null : detectorRules} + {rulesCanFold ? null : ( + <> + + {detectorRules} + + )} ); } diff --git a/public/pages/Rules/components/RuleEditor/RuleEditorFormModel.ts b/public/pages/Rules/components/RuleEditor/RuleEditorFormModel.ts index a46a199bb..4e136fe93 100644 --- a/public/pages/Rules/components/RuleEditor/RuleEditorFormModel.ts +++ b/public/pages/Rules/components/RuleEditor/RuleEditorFormModel.ts @@ -28,7 +28,7 @@ export const ruleEditorStateDefaultValue: RuleEditorFormModel = { description: '', status: '', author: '', - references: [''], + references: [], tags: [], detection: '', level: '',