Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum Perl version explicitly #68

Merged

Conversation

@paultcochrane
Copy link
Contributor

@paultcochrane paultcochrane commented Oct 3, 2018

Perl::MinimumVersion shows that the minimum syntax of the code is Perl
5.6.0 and it is considered good practice to include this information
explicitly in the dist code, hence the addition of the Perl version in
this change.

If you want to have this pull request updated in any way, please just let me know and I'll update and resubmit as appropriate.

Paul Cochrane added 2 commits Oct 3, 2018
`Perl::MinimumVersion` shows that the minimum syntax of the code is Perl
5.6.0 and it is considered good practice to include this information
explicitly in the dist code, hence the addition of the Perl version in
this change.
This way the version information also flows into the dist's metadata,
which can then be used by automated upstream tools such as cpantesters,
CPANTS etc.
@rizen rizen merged commit a643474 into rizen:master Oct 4, 2018
@paultcochrane paultcochrane deleted the paultcochrane:pr/set-min-perl-version-explicitly branch Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.