Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict and warnings pragmas in tests #70

Merged
merged 2 commits into from Oct 4, 2018

Conversation

@paultcochrane
Copy link
Contributor

@paultcochrane paultcochrane commented Oct 3, 2018

It's considered good practice to use the strict and warnings pragmas to Perl source code files, hence they were added to files missing the pragmas. Since the missing pragmas were distributed between the t and author.t directories, the changes were submitted in two commits, one for each directory (just in case you want to cherry-pick the commits). If you want the commits merged, just let me know and I'll make the change and resubmit the PR.

@rizen rizen merged commit 4710ebb into rizen:master Oct 4, 2018
@paultcochrane paultcochrane deleted the paultcochrane:pr/use-strict-warnings-in-tests branch Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.