Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos found in POD #74

Merged
merged 1 commit into from Oct 4, 2018
Merged

Conversation

@paultcochrane
Copy link
Contributor

@paultcochrane paultcochrane commented Oct 4, 2018

While reading through the docs I noticed a couple of typos, which I've fixed in this patch.

@rizen
Copy link
Owner

@rizen rizen commented Oct 4, 2018

How many more pull requests do you have coming? I'm going to accept them all, but I want to wait to push a release to the public until you think you might be done.

@paultcochrane
Copy link
Contributor Author

@paultcochrane paultcochrane commented Oct 4, 2018

Hi! Very cool that you answered :-) I've got one pull request in the pipeline (to fix podchecker warnings), but it'll conflict with the whitespace-removing patch so I was waiting to see if you merge the patch before I work on that anymore. I had thought I could try and improve code coverage, but that's about it I think as far as I had planned. Is there anything other than that that you would like worked on? I'm not Facebook user, so I won't be able to check some things directly, nevertheless, if there's something you'd particularly like to have done, let me know and I'll see what my tuits look like.

@rizen
Copy link
Owner

@rizen rizen commented Oct 4, 2018

Without you being able to actually test Facebook, no there's nothing else I can think of. I'll go ahead and merge all the pull requests so far.

@rizen rizen merged commit 59cf66a into rizen:master Oct 4, 2018
@rizen
Copy link
Owner

@rizen rizen commented Oct 4, 2018

Oh, yeah there is one other thing! Can you please update CHANGES.txt with all the changes you've made?

@paultcochrane
Copy link
Contributor Author

@paultcochrane paultcochrane commented Oct 4, 2018

Sure, no worries!

@paultcochrane paultcochrane deleted the paultcochrane:pr/fix-typos-in-pod branch Oct 5, 2018
@paultcochrane
Copy link
Contributor Author

@paultcochrane paultcochrane commented Oct 17, 2018

Hi there! I think I'm done with my pull requests. It turned out that the whitespace patch fixed all of the podchecker warnings, so fixing those warnings didn't turn into a PR. I don't see me having time to add more tests in the next couple of weeks, so if you want to cut a release go for it. Many thanks for merging these PRs so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.