Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove decompiler autorefresh and properly handle synchronization #2370

Closed
karliss opened this issue Aug 6, 2020 · 0 comments · Fixed by #2402
Closed

Remove decompiler autorefresh and properly handle synchronization #2370

karliss opened this issue Aug 6, 2020 · 0 comments · Fixed by #2402
Assignees
Labels
Decompiler Issues and feature requests related to the decompiler in Cutter

Comments

@karliss
Copy link
Member

karliss commented Aug 6, 2020

Is your feature request related to a problem? Please describe.

Purpose of disabling autorefresh and widget synchronization is very similar - reducing excessive refreshing when clicking around in other widgets.
Benefits of preferring seek synchronization mechanism:

  • single mechanism used across many widgets, easier to learn for users
  • avoids the problem of whether disabling autorefresh should also disable refresh when renaming variables, functions or other changes that would change the code

Describe the solution you'd like

  • Remove autorefresh mechanism from decompiler widget
  • Make sure synchronization action works the same as in other widgets. This might be as simple as connecting refresh to CutterSeekable change instead of global seek change.
  • Make the "sync/unsync offset" action more visible by adding it to decompiler context menu similar to other widgets

When done test that:

  • "sync/unsync" works as intended
  • show in decompiler works and doesn't affect global seek when not synchronized
  • decompiler gets refreshed when function gets renamed
  • decompilation isn't run when decompiler widget is in background or closed

Describe alternatives you've considered

Additional context

@karliss karliss added the Decompiler Issues and feature requests related to the decompiler in Cutter label Aug 6, 2020
@NirmalManoj NirmalManoj self-assigned this Aug 15, 2020
@NirmalManoj NirmalManoj moved this from To do to In progress in Improving Decompiler Widget (GSoC) Aug 20, 2020
@NirmalManoj NirmalManoj moved this from In progress to Done in Improving Decompiler Widget (GSoC) Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Decompiler Issues and feature requests related to the decompiler in Cutter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants