Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated decompiler context menu (skeleton) with an action to copy selected code #2256

Conversation

NirmalManoj
Copy link
Member

@NirmalManoj NirmalManoj commented Jun 19, 2020

Your checklist for this pull request

Detailed description
This PR implements a dedicated context menu (skeleton) for the decompiler widget. Along with that, one action for copying code with right-click as well as with the shortcut QKeySequence::Copy has been implemented.

This is an illustration of the copy action.
CopyAction

Test plan (required)

  • Make sure there are no errors while loading or compiling Cutter.
  • Check the code to see that I did not miss anything important in DecompilerContextMenu.h and DecompilerContextMenu.cpp.
  • Check if the action to copy selected code is working perfectly in all three decompilers we support.

Closing issues
When it gets merged to master, it will close #1753

@NirmalManoj NirmalManoj requested a review from karliss Jun 19, 2020
@NirmalManoj NirmalManoj changed the title Empty decompiler context menu Dedicated decompiler context menu (skeleton) with an action to copy selected code Jun 19, 2020
@NirmalManoj NirmalManoj requested a review from ITAYC0HEN Jun 19, 2020
.travis.yml Outdated Show resolved Hide resolved
Documentation deployment branch reverted back to 'master'
@NirmalManoj NirmalManoj requested a review from karliss Jun 20, 2020
src/menus/DecompilerContextMenu.cpp Outdated Show resolved Hide resolved
src/menus/DecompilerContextMenu.cpp Outdated Show resolved Hide resolved
src/menus/DecompilerContextMenu.cpp Outdated Show resolved Hide resolved
src/menus/DecompilerContextMenu.h Show resolved Hide resolved
src/menus/DecompilerContextMenu.h Outdated Show resolved Hide resolved
src/menus/DecompilerContextMenu.h Outdated Show resolved Hide resolved
src/menus/DecompilerContextMenu.h Outdated Show resolved Hide resolved
src/widgets/DecompilerWidget.cpp Outdated Show resolved Hide resolved
@NirmalManoj
Copy link
Member Author

NirmalManoj commented Jun 20, 2020

@karliss Before writing some comments, I didn't see your previous responses. I was having the idea that GitHub will automatically refresh and show new comments. Sorry about that.

@NirmalManoj NirmalManoj requested a review from karliss Jun 21, 2020
@karliss karliss merged commit b3dec97 into rizinorg:decompiler-refactoring Jun 22, 2020
8 checks passed
NirmalManoj added a commit to NirmalManoj/cutter that referenced this pull request Jul 15, 2020
…elected code (rizinorg#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit to NirmalManoj/cutter that referenced this pull request Jul 15, 2020
…elected code (rizinorg#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit that referenced this pull request Jul 15, 2020
…elected code (#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit to NirmalManoj/cutter that referenced this pull request Jul 15, 2020
…elected code (rizinorg#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit to NirmalManoj/cutter that referenced this pull request Jul 15, 2020
…elected code (rizinorg#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit that referenced this pull request Jul 26, 2020
…elected code (#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit to NirmalManoj/cutter that referenced this pull request Jul 26, 2020
…elected code (rizinorg#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit to NirmalManoj/cutter that referenced this pull request Jul 28, 2020
…elected code (rizinorg#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit that referenced this pull request Jul 30, 2020
…elected code (#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit that referenced this pull request Aug 6, 2020
…elected code (#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit that referenced this pull request Aug 13, 2020
…elected code (#2256)

* Setup CI for decompiler-refactoring branch
NirmalManoj added a commit that referenced this pull request Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants