Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion from GDB register profile to rizin profile #3422

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

ret2libc
Copy link
Member

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

scanf("%s") uses are not safe, limit the number of characters read.

Test plan

...

Closing issues

...

@XVilka
Copy link
Member

XVilka commented Mar 14, 2023

Translation unit diagnostic at <rizin/librz/debug/p/debug_gdb.c:221:4>: 'sscanf' may overflow; destination buffer in argument 3 has size 99, but the corresponding specifier may require size 101

@ret2libc ret2libc added this to the 0.5.2 milestone Mar 14, 2023
@ret2libc ret2libc enabled auto-merge (rebase) March 14, 2023 10:16
@ret2libc ret2libc merged commit d619670 into dev Mar 14, 2023
@XVilka XVilka deleted the gdbr-profile-fix branch March 15, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants