Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotators for new annotations #129

Merged
merged 4 commits into from Aug 11, 2020
Merged

Annotators for new annotations #129

merged 4 commits into from Aug 11, 2020

Conversation

NirmalManoj
Copy link
Member

@NirmalManoj NirmalManoj commented Aug 10, 2020

Detailed description
As part of the Improving Decompiler Widget project, many new types of annotations have been added. This was merged to radare2 by PR #17429.

The annotators for these new annotations were implemented and merged to the decompiler-refactoring branch by the following PRs:

  1. Function name annotation annotator implemented #123 - Function name annotation annotator implemented.
  2. Annotation for constant and global variables #124 - Annotator for constant and global variables.
  3. Annotator for local variables and function paramters #128 - Annotator for local variables and function parameters.

...

Test plan

  1. Fetch the master of radare2 and compile.
  2. Compile this PR.
  3. Run tests in r2ghidra-dec and make sure the new tests are passing. New tests added tests all the annotators that were implemented by the linked PRs.
  4. Run pdgj~{} on some small executables to see if the output is as expected.
  5. Have a look at the code.
  6. If you want, you can fetch the decompiler-refactoring branch in Cutter and test all the new actions in the decompiler context menu. But I don't think that is necessary.

@NirmalManoj NirmalManoj self-assigned this Aug 10, 2020
@NirmalManoj NirmalManoj marked this pull request as ready for review Aug 10, 2020
@NirmalManoj NirmalManoj requested review from karliss, thestr4ng3r and ITAYC0HEN and removed request for karliss Aug 10, 2020
@NirmalManoj
Copy link
Member Author

NirmalManoj commented Aug 10, 2020

An unrelated test was failing. So I modified the expected output for it to pass. This is with the assumption that the test failed due to the improvements in radare2. Please check that test also.

Copy link
Member

@thestr4ng3r thestr4ng3r left a comment

Yeah that test doesn't look wrong either way, so it should be fine. I've rearranged the commits a bit so if this becomes green, then lgtm. Great job on all the changes!

Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Good work!

@thestr4ng3r thestr4ng3r merged commit 16c824b into master Aug 11, 2020
4 checks passed
@NirmalManoj NirmalManoj moved this from In progress to Done in Improving Decompiler Widget (GSoC) Aug 12, 2020
@Surendrajat Surendrajat deleted the decompiler-refactoring branch Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants