Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing schemes : problem with "eolfilled" #359

Closed
Paulot2 opened this issue Feb 15, 2018 · 35 comments

Comments

Projects
None yet
4 participants
@Paulot2
Copy link

commented Feb 15, 2018

As you can see the "eolfilled" parameter is not performed in that case (registry files) :

  • other parameters (colors, bold, italic etc) work as intended for the registry files scheme ;
  • the eolfilled parameter triggers the expected behavior for the configuration files scheme.

2018-02-15 07_45_12-programme_notepad3 reg

@RaiKoHoff RaiKoHoff added the duplicate label Feb 15, 2018

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2018

Please see discussion at #352

@Paulot2

This comment has been minimized.

Copy link
Author

commented Feb 15, 2018

OK.

@Paulot2 Paulot2 closed this Feb 15, 2018

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2018

I think, the author of the Registry Files lexer decided not to support the eolfilled attribute to the Added Key style, cause you can have e.g. a comment after it (or he just don't thought of it):
image

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2018

In beta version 3.18.216.888, I changed the Registry File lexer a little bit to support the eolfilled attribute for Added Key style. Please try - test feedback needed.
(How to subscribe to beta channel: #160)
(Or at https://drive.google.com/drive/folders/0B7X3F11Wq7qSZmNacmNJaGR0MFk?usp=sharing (exception for new testers))

@craigo-

This comment has been minimized.

Copy link

commented Feb 16, 2018

You'd better reopen this issue, @RaiKoHoff 😄

Beta build 3.18.216.888.

I've discovered some odd behaviour with comments in a .reg file. If you comment a line immediately after a header line, it becomes eolfilled (and sometimes subsequent lines too).

For example, I've placed the caret in line 9:
image

...and pressed Ctrl+Q:
image

The fill also survives an Undo operation:
image

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2018

Please test beta version 3.18.216.889.

@RaiKoHoff RaiKoHoff reopened this Feb 16, 2018

@Paulot2

This comment has been minimized.

Copy link
Author

commented Feb 16, 2018

v888, same thing (line 16) :

2018-02-16 15_13_56-_ programme_notepad3 reg d__bonus_viewers_edition_notepad3 - notepad3 adminis

v890 seems fine for that bug, but eolfilled works only for the first occurence :

2018-02-16 15_19_56-_ programme_notepad3 reg d__bonus_viewers_edition_notepad3 - notepad3 adminis

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2018

Programming the lexers (even if it is a simple one like the Registry lexer) seems not to be so simple 😁
Please try beta version 3.18.216.891.

@Paulot2

This comment has been minimized.

Copy link
Author

commented Feb 16, 2018

v891 is ok : eolfilled on/off works as expected + no more weird behavior on the next line.

2018-02-16 15_52_25-_ programme_notepad3 reg d__bonus_viewers_edition_notepad3 - notepad3 adminis

"eolfilled" for that part of the registry files style is just a small habit from notepad2-mod, and yes it is possible to fall back to the configuration files style.

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2018

Thank you for your support. If no further problems occur, that lexer will be part of next Notepad3 release.

@Paulot2

This comment has been minimized.

Copy link
Author

commented Feb 16, 2018

Fine. I will use 3.18.216.891 until next release. You can close the issue. And thanks too.

@Paulot2

This comment has been minimized.

Copy link
Author

commented Feb 16, 2018

Difference between 862 and 891 : toolbar labels messy on 891, fine on 862...

2018-02-16 17_41_55-notepad3 ini d__bonus_viewers_edition_notepad3 - notepad3 administrator

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2018

@craigo- : The Icons got a new (factory) ordering (not numbering) according to issue: #327.
We forgot to map the order numbers of Toolbar Labels naming in the settings file accordingly.
Will fix this ...

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 16, 2018

Please check beta version 3.18.216.892.

@craigo-

This comment has been minimized.

Copy link

commented Feb 17, 2018

Another feature I was not aware of 😄

However, there are a few more tweaks necessary, I think (tested version: beta build 3.18.216.892)...

image

;03=metapath -> Browse (to match the tooltip - keep it technology-agnostic)
;16=Config -> Customize Schemes (to match the tooltip)
;20=Copy All -> Delete (incorrect!)
;22=Print -> Favorites (incorrect!)
;23=Favorites -> Add to Favorites (incorrect!)
;24=Add -> Toggle All Folds (incorrect!)
;25=(unlabeled) -> Execute Document (currently has no label)

i.e., in Notepad3.ini:

[Toolbar Labels]
;01=New
;02=Open
;03=Browse
;04=Save
;05=Undo
;06=Redo
;07=Cut
;08=Copy
;09=Paste
;10=Find
;11=Replace
;12=Word Wrap
;13=Zoom In
;14=Zoom Out
;15=Scheme
;16=Customize Schemes
;17=Exit
;18=Save As
;19=Save Copy
;20=Delete
;21=Print
;22=Favorites
;23=Add to Favorites
;24=Toggle All Folds
;25=Execute Document
@Paulot2

This comment has been minimized.

Copy link
Author

commented Feb 17, 2018

Bug with Guid in key path's style :

2018-02-17 10_50_36-img_drive 1 redo reg d__bonus_ajpan_desktop - notepad3 administrator

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 18, 2018

Please check beta version 3.18.218.893.

@hpwamr

This comment has been minimized.

Copy link
Collaborator

commented Feb 18, 2018

Hello, I just want to post here a conversation found on the site: www.rizonesoft.com/notepad3
From: coch , February 17, 2018
Hi,
Thanks for replying to me, and I will be reading on development on #359
I tested the new versions 3.18.216.891 and 3.18.216.892 and did have any visible problems with them, although the “eolfilled” parameter only appears to be enabled for “Added Keys”, is that right?
I’d be interested in “eolfilled” also be enabled for Comments in registry files, unless that causes issues. You bring a good point in #359 about registry files having comments right after Added Keys, and not sure how this would be dealt with (in Notepad2-mod, using the Configuration files lexer the “Added Keys” eolfilled argument would prevail when adding a comment on the same line).

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2018

I changed the "Registry Files" lexer, so that attribute eolfilled is enabled for all styles of this lexer.
Please test beta version 3.18.219.894.

@craigo-

This comment has been minimized.

Copy link

commented Feb 19, 2018

Bug with Guid in key path's style :

Please check beta version 3.18.218.893.

Beta build 893, 894: we still seem to have a problem:

image

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2018

This has not been the bug described above, cause the "GUID in Key Path" has its own styling, which is applied here => works as designed.
(The bug above was "missing following Key Path styling on GUID's first occurrence")

@craigo-

This comment has been minimized.

Copy link

commented Feb 19, 2018

You are absolutely right, @RaiKoHoff... Withdrawn 😄

@ghost

This comment has been minimized.

Copy link

commented Feb 19, 2018

(I'm coch who posted on www.rizonesoft.com/notepad3 sorry for not posting here sooner, I lost my login info for github and had to create a new account).

Thanks a lot for enabling eolfilled for all styles for the "Registry Files" lexer. It appears to be working correctly for me, and I am not seeing any issue that could have been caused by this change.

@Paulot2

This comment has been minimized.

Copy link
Author

commented Feb 19, 2018

v895. I don't know if the second occurence of hex's style is buggy.

If the string "{5C4F28B5-F869-4E84-8E60-F11DB97C5CC7}" is replaced by a random string "jsdhqmoszeru", i.e. without the fisrt { , the style is restored.

2018-02-19 16_33_14-streams reg d__bonus_securite_restauration_cloneapp_backup old - notepad3 adm

@hpwamr

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2018

If I replace in the key a digit, eg: "0" by a letter, eg: "Q, W, K", the eolfilled is displayed on a complete line (idem if I delete a digit or a letter in the key ).
I guess it's normal behavior?

reg_test01

@ghost

This comment has been minimized.

Copy link

commented Feb 19, 2018

@ hpwamr: Yes this is normal. GUID's must follow the following scheme with regard to the number of characters: 8-4-4-4-12. This explains why adding or deleting a character makes it no longer recognized as a GUID, and the corresponding style therefore doesn't apply.
Furthermore, only letters A-F are allowed, in your examples you used Q and W, and again this breaks recognition as a GUID. I'd say this works as expected.

@ Paulot2, I am seeing the same issue, but not only with hex, and it's not just the second hex, it's all occurrences of hex (even the first one, of them if the key is a GUID. Happens with all types of registry entries too, not just hex.
I made a simple example in my screenshot below. Version 862 didn't have this problem.
image

@hpwamr

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2018

@leyabe Thanks for the explanation 👍

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2018

Nice finding - please test beta version 3.18.219.896

@ghost

This comment has been minimized.

Copy link

commented Feb 19, 2018

Thanks. Version 3.18.219.896 appears to be all good on my end.

@craigo-

This comment has been minimized.

Copy link

commented Feb 20, 2018

Beta build 3.18.220.899: I see that the "Toolbar Labels" section in the as-shipped Notepad3.ini file has been changed (thanks), but there are still a couple of errors:

image

  • 21 should be "Print"
  • 23 should be "Add to Favorites"

@RaiKoHoff RaiKoHoff referenced this issue Feb 21, 2018

Merged

Bug Fix 0221 #373

@craigo-

This comment has been minimized.

Copy link

commented Feb 22, 2018

@RaiKoHoff, did you see my comments on the above PR #373?

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 22, 2018

... I just wanted to answer soon: I did the change after publishing beta builds .901, .902.
So it will be in the release and in the upcoming beta build .903 (changed compiler optimizations). 😬

@craigo-

This comment has been minimized.

Copy link

commented Feb 22, 2018

Cool - thanks 😄

@RaiKoHoff

This comment has been minimized.

Copy link
Collaborator

commented Feb 28, 2018

@Paulot2 : Please test release version 3.18.223.908 and close this issue if solved.

@Paulot2

This comment has been minimized.

Copy link
Author

commented Mar 1, 2018

I use this version since its release ; all is well.
Many thanks. I close the issue.

@Paulot2 Paulot2 closed this Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.