Convert relationships for Enclosure, Episode, Sites into M2M to allow mix and match show creation #16

djangolackey · 2014-09-17T14:31:27Z

This is based on conversations in issue #15

update admin form to include enclosure on episode;update models to make slug unique in all cases because of the m2m relationships with shows and sites; update forms to include enclosure on the episode admin panel; update migration to include the model change for slug modify model for enclosure to make episode a ManyToManyField rather than having a ForeignKey on the Episode. This will continue to allow Episodes to have Enclosures of various types and Enclosures to be used on multiple Episodes; modifiy migrations to match updates to form to validate that only one enclosure for each mimetype can be attached to a particular episode corrections to the validation of the Enclosure model admin form and the migration to properly handle AutoSlug update managers and views to use the plural form for sites and shows for the new ManyToMany field; update the model to use the first shows slug when there is more than one and the current show it not known update the ordering of enclosures to include the url because the MimeType alone provides a fairly random list fix typo in the migration script

update fork branch from rizumu repo

update fork branch from rizumu repo via master

rizumu · 2014-09-17T14:50:56Z

I pushed a fix to master to exclude the migrations directory from the linting. You can merge master in to your branch or cherry-pick that commit. Then you'll want to run flake8 --max-line-length=100 --exclude=docs/conf.py,migrations . to fix for the syntax errors, there aren't too many, mostly stripping whitespace.

exclude migrations -- merge master from rizumu

merge down master in to branch

…o-podcasting into update_models

coveralls · 2014-09-18T02:56:39Z

Coverage decreased (-7.31%) when pulling e146e45 on djangolackey:update_models into c35df6b on rizumu:master.

…PS setting for licenses rather the only looking for the ability to import licenses; this is because the migration will fail if the module is installed but not in the INSTALLED_APPS with an obsure error; also moved the creation of the ForeignKey to an Alter portion of the initial migration so the dependency is not created with License since it might not be installed

coveralls · 2014-09-18T04:45:11Z

Coverage decreased (-5.58%) when pulling dd89206 on djangolackey:update_models into c35df6b on rizumu:master.

djangolackey · 2014-09-18T04:52:12Z

It's interesting that it passes tests (or at least the build succeeds) on some newer versions of Django, but not others. I think we are down to actual test failures now. mostly where I've changed site to sites and episode to episodes and such.

Can I assume we are looking for success on all of the Travis environment tests? .

…se a model form without a fields declaration is deprecated, which makes this class purposeless; Update Forms to add duration to EnclosureForm so it can be used for AdminEnclosureForm; update tests to take into account the ManyToMany fields now present. All tests passing in Python 2.7 and Django 1.7

coveralls · 2014-09-18T06:23:03Z

Coverage decreased (-2.06%) when pulling 21b743c on djangolackey:update_models into c35df6b on rizumu:master.

coveralls · 2014-09-18T06:36:48Z

Coverage decreased (-0.6%) when pulling a2a46fe on djangolackey:update_models into c35df6b on rizumu:master.

djangolackey · 2014-09-18T06:41:12Z

It appears there is one failure on the Python 3.3 version of the django master branch. I'm stumped on that one really. The last commit fixed an issue with the str def that should have been an issue forever and always on Python 2.6 according to the interwebs.

So what do you think?

Thanks,

rizumu · 2014-10-01T15:07:03Z

@djangolackey sorry, somehow this slipped past me. I'll test it out locally and get back to you asap.

rizumu · 2014-10-01T17:08:50Z

@djangolackey I've tried to keep it as simple as possible, but I'm not able to get the migration working. The steps I've taken are:

start with a fresh database using the master branch of rizumu/django-podcasting (I also have django-taggit, django-licenses and easy-thumbnails installed. Django 1.7 with postgres)
switch to your branch and run ./mange.py migrate - see the traceback below

If it is working for you, could you please list the steps that you are taking? I'd like to get this merged, but if it is too much trouble to get the migrations working, we can look into doing a manual migration: ex. ./manage.py dumpdata podcasting --indent=4 --format=yaml > podcasting.yaml, drop the podcasting tables, create new tables from your branch, update the podcasting.yaml to reflect the db changes and finally do a ./manage.py loaddata podcasting.yaml.

Running migrations:
  Applying podcasting.0003_auto_20141001_1616...Traceback (most recent call last):
  File "./manage.py", line 12, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/core/management/__init__.py", line 385, in execute_from_command_line
    utility.execute()
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/core/management/__init__.py", line 377, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/core/management/base.py", line 288, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
    output = self.handle(*args, **options)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/core/management/commands/migrate.py", line 160, in handle
    executor.migrate(targets, plan, fake=options.get("fake", False))
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/migrations/executor.py", line 63, in migrate
    self.apply_migration(migration, fake=fake)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/migrations/executor.py", line 97, in apply_migration
    migration.apply(project_state, schema_editor)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/migrations/migration.py", line 107, in apply
    operation.database_forwards(self.app_label, schema_editor, project_state, new_state)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/migrations/operations/fields.py", line 131, in database_forwards
    schema_editor.alter_field(from_model, from_field, to_field)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/backends/schema.py", line 509, in alter_field
    self._alter_field(model, old_field, new_field, old_type, new_type, old_db_params, new_db_params, strict)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/backends/schema.py", line 671, in _alter_field
    params,
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/backends/schema.py", line 98, in execute
    cursor.execute(sql, params)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/backends/utils.py", line 81, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
    return self.cursor.execute(sql, params)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/Users/rizumu/.virtualenvs/scenemachine/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
    return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: column "license_id" cannot be cast automatically to type integer
HINT:  Specify a USING expression to perform the conversion.

djangolackey · 2014-10-22T03:09:19Z

I'm sorry I've been out of pocket for a couple of weeks. There was an issue with how django-licenses is loaded. Depending on whether licenses is present or not you have to alter the model field from a varchar to a foreignkey. I'm testing another option where the field isn't created except through the check. I'll let you know when I complete my tests.

I've chosen not to depend on whether the app available on the path, but instead to check the settings.INSTALLED_APPS for it. This way even if it's available, it won't be used unless it's actually in the installed apps.

thanks,

…nstalled apps rather than creating it as a varchar and converting it to a foreignkey if the app is installed. This is because if the initial isn't run at database creation the license has to be converted, which forces migration to try and treat it as a varchar to foreignkey conversion that it can't accomplish

coveralls · 2014-10-22T03:37:00Z

Coverage decreased (-1.97%) when pulling 6fc84db on djangolackey:update_models into c35df6b on rizumu:master.

djangolackey · 2014-10-22T03:38:45Z

I've pushed an update that changes the initial migration. Rather than setting the field as a varchar and then converting it to a foreignkey if the Licenses app is installed, I'm delaying the creation of that field until after other pieces are done and basing the creation on the presence of licenses in settings.INSTALLED_APPS. The benefit here is that the field doesn't have to be converted if the app exists, which appears to be where the error is coming from.

One thing to note, if a person installs django-podcasting and runs manage.py migrate without licensing in their INSTALLED_APPS and then later adds licensing to their INSTALLED_APPS, they will have a bad time. This is because the field will get created as a varchar field, which will not work with a ForeignKey. They will have to migrate the Field themselves to get it to work.

The only other option is to create both a varchar and a foreignkey (only if licenses is installed) and modify the forms.py to only show one of the fields in the admin depending on if licenses is present.

I'm not sure if you want to speak to this in the docs, or what.

Thanks,

…hat it creates under postgres

djangolackey · 2014-11-17T02:53:24Z

Latest push handles the initial migration differently for the license app. I've set up a postgres database and tested it there. Issue was the the migrations.RunPython doesn't actually handle the migrations.AddField functionality correctly. I needed to add the conditional for licenses in an different way.

coveralls · 2014-11-17T02:58:48Z

Coverage decreased (-1.97%) when pulling 030428d on djangolackey:update_models into c35df6b on rizumu:master.

rizumu · 2014-11-18T15:42:53Z

@djangolackey I'll test this out in the next couple days and get it merged asap. Sorry for the delay.

…is set up like the intended model

coveralls · 2014-11-23T00:43:50Z

Coverage decreased (-0.74%) when pulling 5713503 on djangolackey:update_models into c35df6b on rizumu:master.

rizumu · 2014-11-28T03:38:39Z

@djangolackey everything looks good. I'll need some time to update my custom forms on my project before I can start using it, but I'm going to merge this in and tag a new version since everything is now working nicely.

Convert relationships for Enclosure, Episode, Sites into M2M to allow mix and match show creation

djangolackey added 4 commits September 14, 2014 21:38

initial migrations created from 0.9.10

7175c92

Merge pull request #1 from rizumu/master

d8b09fd

update fork branch from rizumu repo

Merge pull request #2 from djangolackey/master

8aff7fe

update fork branch from rizumu repo via master

djangolackey mentioned this pull request Sep 17, 2014

Architecture question; before I fork and start coding #15

Closed

djangolackey added 4 commits September 17, 2014 21:23

Merge pull request #3 from rizumu/master

5dd1027

exclude migrations -- merge master from rizumu

Merge pull request #4 from djangolackey/master

42ca817

merge down master in to branch

correct syntax issues identified by flake8

17a453b

Merge branch 'update_models' of https://github.com/djangolackey/djang…

e146e45

…o-podcasting into update_models

djangolackey added 2 commits September 18, 2014 06:12

fix flake8 spacing issues

21b743c

update format string to use indices required by Python 2.6 failing tests

a2a46fe

modify initial migration to create the license field differently so t…

030428d

…hat it creates under postgres

import django.utils.translation to the migration so that the license …

5713503

…is set up like the intended model

rizumu added a commit that referenced this pull request Nov 28, 2014

Merge pull request #16 from djangolackey/update_models

3d595c0

Convert relationships for Enclosure, Episode, Sites into M2M to allow mix and match show creation

rizumu merged commit 3d595c0 into rizumu:master Nov 28, 2014

rizumu mentioned this pull request Nov 28, 2014

make this work even with unicode names #17

Closed

djangolackey deleted the update_models branch December 2, 2014 01:28

rizumu mentioned this pull request Jun 13, 2017

ValueError at /admin/podcasting/episode/add/ #27

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert relationships for Enclosure, Episode, Sites into M2M to allow mix and match show creation #16

Convert relationships for Enclosure, Episode, Sites into M2M to allow mix and match show creation #16

djangolackey commented Sep 17, 2014

rizumu commented Sep 17, 2014

coveralls commented Sep 18, 2014

coveralls commented Sep 18, 2014

djangolackey commented Sep 18, 2014

coveralls commented Sep 18, 2014

coveralls commented Sep 18, 2014

djangolackey commented Sep 18, 2014

rizumu commented Oct 1, 2014

rizumu commented Oct 1, 2014

djangolackey commented Oct 22, 2014

coveralls commented Oct 22, 2014

djangolackey commented Oct 22, 2014

djangolackey commented Nov 17, 2014

coveralls commented Nov 17, 2014

rizumu commented Nov 18, 2014

coveralls commented Nov 23, 2014

rizumu commented Nov 28, 2014

Convert relationships for Enclosure, Episode, Sites into M2M to allow mix and match show creation #16

Convert relationships for Enclosure, Episode, Sites into M2M to allow mix and match show creation #16

Conversation

djangolackey commented Sep 17, 2014

rizumu commented Sep 17, 2014

coveralls commented Sep 18, 2014

coveralls commented Sep 18, 2014

djangolackey commented Sep 18, 2014

coveralls commented Sep 18, 2014

coveralls commented Sep 18, 2014

djangolackey commented Sep 18, 2014

rizumu commented Oct 1, 2014

rizumu commented Oct 1, 2014

djangolackey commented Oct 22, 2014

coveralls commented Oct 22, 2014

djangolackey commented Oct 22, 2014

djangolackey commented Nov 17, 2014

coveralls commented Nov 17, 2014

rizumu commented Nov 18, 2014

coveralls commented Nov 23, 2014

rizumu commented Nov 28, 2014