Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
branch: timelapse
Commits on Dec 9, 2013
  1. @burg
  2. @burg

    Probes: move the new probe expression entry popup to gutter context m…

    burg authored
    …enu.
    
    Fixes #309.
    
    We used to want the quick-add for probe expressions to be in the gutter,
    but CodeMirror bugs prevented that from working. So instead it was added
    as a shift-click gutter action. Now that the gutter has a context menu,
    the quick-add dialog is triggered from the "Add Probe Expression" context
    menu item.
  3. @burg

    Probes: fix breakpoint mode inconsistency when creating from popup menu.

    burg authored
    Fixes #419.
    
    This fixes two things:
    
    The Breakpoint.mode setter didn't check the validity of the supplied mode.
    Now, if you try to set auto-continue when no actions are attached, it will
    instead set the mode to enabled.
    
    There was a race between setting the probe breakpoint action and setting
    the breakpoint's mode to auto-continue. A short timer was added as a
    temporary workaround until Breakpoints have an API for batching mutations.
  4. @burg

    Probes: animate breakpoint tree element when a probe sample is gathered.

    burg authored
    This re-adds the old animation behavior.
    
    Fixes #418.
  5. @burg
Commits on Dec 8, 2013
  1. [WK2] Add ENABLE_NETWORK_PROCESS flag

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=125421
    
    Add support to build with the Network Process enabled.
    
    Patch by Brian Holt <brian.holt@samsung.com> on 2013-12-08
    Reviewed by Martin Robinson.
    
    * Scripts/webkitperl/FeatureList.pm:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. Fold typedArray.length if typedArray is constant

    fpizlo@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=125252
    
    Source/JavaScriptCore: 
    
    Reviewed by Sam Weinig.
            
    This was meant to be easy. The problem is that there was no good place for putting
    the folding of typedArray.length to a constant. You can't quite do it in the
    bytecode parser because at that point you don't yet know if typedArray is really
    a typed array. You can't do it as part of constant folding because the folder
    assumes that it can opportunistically forward-flow a constant value without changing
    the IR; this doesn't work since we need to first change the IR to register a
    desired watchpoint and only after that can we introduce that constant. We could have
    done it in Fixup but that would have been awkward since Fixup's code for turning a
    GetById of "length" into GetArrayLength is already somewhat complex. We could have
    done it in CSE but CSE is already fairly gnarly and will probably get rewritten.
            
    So I introduced a new phase, called StrengthReduction. This phase should have any
    transformations that don't requite CFA or CSE and that it would be weird to put into
    those other phases.
            
    I also took the opportunity to refactor some of the other folding code.
            
    This also adds a test, but the test couldn't quite be a LayoutTests/js/regress so I
    introduced the notion of JavaScriptCore/tests/stress.
            
    The goal of this patch isn't really to improve performance or anything like that.
    It adds an optimization for completeness, and in doing so it unlocks a bunch of new
    possibilities. The one that I'm most excited about is revealing array length checks
    in DFG IR, which will allow for array bounds check hoisting and elimination.
    
    * CMakeLists.txt:
    * GNUmakefile.list.am:
    * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
    * JavaScriptCore.xcodeproj/project.pbxproj:
    * dfg/DFGAbstractInterpreterInlines.h:
    (JSC::DFG::::executeEffects):
    * dfg/DFGClobberize.h:
    (JSC::DFG::clobberize):
    * dfg/DFGFixupPhase.cpp:
    (JSC::DFG::FixupPhase::fixupNode):
    * dfg/DFGGraph.cpp:
    (JSC::DFG::Graph::tryGetFoldableView):
    (JSC::DFG::Graph::tryGetFoldableViewForChild1):
    * dfg/DFGGraph.h:
    * dfg/DFGNode.h:
    (JSC::DFG::Node::hasTypedArray):
    (JSC::DFG::Node::typedArray):
    * dfg/DFGNodeType.h:
    * dfg/DFGPlan.cpp:
    (JSC::DFG::Plan::compileInThreadImpl):
    * dfg/DFGPredictionPropagationPhase.cpp:
    (JSC::DFG::PredictionPropagationPhase::propagate):
    * dfg/DFGSafeToExecute.h:
    (JSC::DFG::safeToExecute):
    * dfg/DFGSpeculativeJIT.cpp:
    (JSC::DFG::SpeculativeJIT::jumpForTypedArrayOutOfBounds):
    (JSC::DFG::SpeculativeJIT::compileConstantIndexedPropertyStorage):
    * dfg/DFGSpeculativeJIT32_64.cpp:
    (JSC::DFG::SpeculativeJIT::compile):
    * dfg/DFGSpeculativeJIT64.cpp:
    (JSC::DFG::SpeculativeJIT::compile):
    * dfg/DFGStrengthReductionPhase.cpp: Added.
    (JSC::DFG::StrengthReductionPhase::StrengthReductionPhase):
    (JSC::DFG::StrengthReductionPhase::run):
    (JSC::DFG::StrengthReductionPhase::handleNode):
    (JSC::DFG::StrengthReductionPhase::foldTypedArrayPropertyToConstant):
    (JSC::DFG::performStrengthReduction):
    * dfg/DFGStrengthReductionPhase.h: Added.
    * dfg/DFGWatchpointCollectionPhase.cpp:
    (JSC::DFG::WatchpointCollectionPhase::handle):
    * ftl/FTLCapabilities.cpp:
    (JSC::FTL::canCompile):
    * ftl/FTLLowerDFGToLLVM.cpp:
    (JSC::FTL::LowerDFGToLLVM::compileNode):
    (JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
    (JSC::FTL::LowerDFGToLLVM::compilePutByVal):
    (JSC::FTL::LowerDFGToLLVM::typedArrayLength):
    * jsc.cpp:
    (GlobalObject::finishCreation):
    (functionTransferArrayBuffer):
    * runtime/ArrayBufferView.h:
    * tests/stress: Added.
    * tests/stress/fold-typed-array-properties.js: Added.
    (foo):
    
    Tools: 
    
    Reviewed by Sam Weinig.
            
    Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
    should put tests that run just like JSRegress but don't run as part of LayoutTests.
    Currently I'm using it for tests that require some surgical support from jsc.cpp.
    
    * Scripts/run-javascriptcore-tests:
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. [Cocoa] Remove webProcessPlugInInitialize: from the WKWebProcessPlugI…

    weinig@apple.com authored
    …n protocol
    
    
    https://bugs.webkit.org/show_bug.cgi?id=125405
    
    Reviewed by Dan Bernstein.
    
    * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
    * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
    (WebKit::InjectedBundle::load):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. [WK2] Guard include of SecItemShim.h with ENABLE(SEC_ITEM_SHIM)

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=125415
    
    Patch by Brian Holt <brian.holt@samsung.com> on 2013-12-08
    Reviewed by Gustavo Noronha Silva.
    
    * NetworkProcess/NetworkProcess.cpp:
    * UIProcess/Network/NetworkProcessProxy.cpp:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. [GTK] Do not skip attributes with only custom setter

    carlosgc@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=125417
    
    Reviewed by Gustavo Noronha Silva.
    
    For attributes with a custom setter, we now generate the code as a
    read-only attribute with a getter method, unless it also has a
    custom getter in which case the attribute is skipped.
    
    * bindings/gobject/GNUmakefile.am: Generate WebKitDOMMediaController
    that is now required by an attribute having a custom setter.
    * bindings/gobject/WebKitDOMCustom.cpp: Remove methods that are now generated.
    * bindings/gobject/WebKitDOMCustom.h: Ditto.
    * bindings/gobject/WebKitDOMCustom.symbols: Ditto.
    * bindings/gobject/webkitdom.symbols: Add new symbols.
    * bindings/scripts/CodeGeneratorGObject.pm:
    (SkipAttribute): Do not skip attributes having a custom setter.
    (GetWriteableProperties): Do not include attributes having a
    custom setter.
    (GenerateProperty): Do not return early for attributes having
    custom setter.
    (GenerateFunctions): Do not generate setter for attributes having
    a custom setter.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. [GTK] Do not generate new dispatch_event methods marked as deprecated

    carlosgc@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=125416
    
    Reviewed by Gustavo Noronha Silva.
    
    * bindings/scripts/CodeGeneratorGObject.pm:
    (SkipFunction): Skip dispatch_event methods for objects
    implementing EventTarget interface unless they are already
    deprecated.
    (GenerateFunction): Pass also the parentNode to SkipFunction().
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. [gdb] Update printers for WTF::CString, JSC::JSString

    zandobersek@gmail.com authored
    https://bugs.webkit.org/show_bug.cgi?id=124600
    
    Reviewed by Gustavo Noronha Silva.
    
    Update the two printers after they fell behind the changes in implementation.
    
    * gdb/webkit.py:
    (WTFCStringPrinter.to_string):
    (JSCJSStringPrinter.to_string):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  8. [webkitpy] Add a WestonDriver unit test

    zandobersek@gmail.com authored
    https://bugs.webkit.org/show_bug.cgi?id=125408
    
    Reviewed by Gustavo Noronha Silva.
    
    Add a webkitpy unit test for the Weston driver.
    
    * Scripts/webkitpy/port/westondriver_unittest.py: Added.
    (WestonDriverTest):
    (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
    (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
    the server environment contains proper WAYLAND and GDK_BACKEND entries.
    (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
    the driver cleans up the temporary directory.
    (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
    (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. [Gtk] install-dependencies doesn't install libgtk-3-dev

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=125320
    
    Patch by Brendan Long <b.long@cablelabs.com> on 2013-12-08
    Reviewed by Gustavo Noronha Silva.
    
    * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  10. Unreviewed GTK gardening.

    zandobersek@gmail.com authored
    Removing the baseline added in r160283. It's not really required, the failure is originating
    in an unnecessary and wrong patch that's applied on the Freetype source tree that's used in the
    GTK's Jhbuild setup. That patch will be removed in the near future, but until then the failure
    of accessibility/press-targers-center-point.html should be handled through an expectation.
    
    * platform/gtk/TestExpectations:
    * platform/gtk/accessibility/press-targets-center-point-expected.txt: Removed.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  11. Unreviewed GTK gardening. Adding expectations for the current test fa…

    zandobersek@gmail.com authored
    …ilures.
    
    Adding a GTK-specific baseline for a recently introduced a11y test.
    
    * platform/gtk/TestExpectations:
    * platform/gtk/accessibility/press-targets-center-point-expected.txt: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  12. [MSE] Bring end-of-stream algorithm section up to current spec.

    jer.noble@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=125270
    
    Reviewed by Darin Adler.
    
    Source/WebCore:
    
    Test: media/media-source/media-source-end-of-stream.html
    
    Separate the "endOfStream()" method from the "end of stream algorithm".
    
    * Modules/mediasource/MediaSource.cpp:
    (WebCore::SourceBufferIsUpdating): Added predicate function.
    (WebCore::MediaSource::endOfStream): Call streamEndedWithError().
    (WebCore::MediaSource::streamEndedWithError): Added.
    * Modules/mediasource/MediaSource.h:
    * Modules/mediasource/SourceBuffer.cpp:
    (WebCore::SourceBuffer::appendBufferTimerFired): Call streamEndedWithError().
    (WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
    * Modules/mediasource/SourceBuffer.h:
    * html/HTMLMediaElement.cpp:
    (HTMLMediaElement::mediaLoadingFailedFatally): Renamed from mediaEngineError.
    (HTMLMediaElement::mediaLoadingFailed): Call renamed method.
    * html/HTMLMediaElement.h:
    * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
    (WebCore::MediaSourcePrivateAVFObjC::markEndOfStream): Set load state to Loaded.
    * platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
    (WebCore::MockMediaPlayerMediaSource::setNetworkState): Simple setter.
    * platform/mock/mediasource/MockMediaPlayerMediaSource.h:
    * platform/mock/mediasource/MockMediaSourcePrivate.cpp:
    (WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate): Set the intitial duration to NaN.
    (WebCore::MockMediaSourcePrivate::markEndOfStream): Set load state to Loaded.
    
    LayoutTests:
    
    * media/media-source/media-source-end-of-stream-expected.txt: Added.
    * media/media-source/media-source-end-of-stream.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  13. [MSE][Mac] Crash when removing MediaSource from HTMLMediaElement.

    jer.noble@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=125269
    
    Reviewed by Sam Weinig.
    
    Fixes the media/media-source/media-source-fastseek.html test when run with MallocScribble enabled.
    
    It's possible for a SourceBufferPrivateAVFObjC to outlive its MediaSourcePrivateAVFObjC, so
    make sure to clear the pointer from the former to the latter when the latter is destroyed.
    That means we now have to check to see if the pointer to the latter is still valid at every
    call site.
    
    As a drive-by fix, rename m_parent to m_mediaSource to more accurately reflect what the pointer
    points to.
    
    * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
    (WebCore::MediaSourcePrivateAVFObjC::~MediaSourcePrivateAVFObjC): Clear the SourceBuffer's backpointer.
    * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
    (WebCore::SourceBufferPrivateAVFObjC::clearMediaSource):
    * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
    (WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC): Rename m_parent -> m_mediaSource.
    (WebCore::SourceBufferPrivateAVFObjC::append): Check m_mediaSource before calling.
    (WebCore::SourceBufferPrivateAVFObjC::removedFromMediaSource): Ditto.
    (WebCore::SourceBufferPrivateAVFObjC::readyState): Ditto.
    (WebCore::SourceBufferPrivateAVFObjC::setReadyState): Ditto.
    (WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled): Ditto.
    (WebCore::SourceBufferPrivateAVFObjC::flushAndEnqueueNonDisplayingSamples): Ditto.
    (WebCore::SourceBufferPrivateAVFObjC::enqueueSample): Ditto.
    (WebCore::SourceBufferPrivateAVFObjC::setActive): Ditto.
    * platform/mock/mediasource/MockMediaSourcePrivate.cpp:
    (WebCore::MockMediaSourcePrivate::~MockMediaSourcePrivate): Clear the SourceBuffer's backpointer.
    * platform/mock/mediasource/MockSourceBufferPrivate.cpp:
    (WebCore::MockSourceBufferPrivate::MockSourceBufferPrivate): Rename m_parent -> m_mediaSource.
    (WebCore::MockSourceBufferPrivate::removedFromMediaSource): Check m_mediaSource before calling.
    (WebCore::MockSourceBufferPrivate::readyState): Ditto.
    (WebCore::MockSourceBufferPrivate::setReadyState): Ditto.
    (WebCore::MockSourceBufferPrivate::setActive): Ditto.
    * platform/mock/mediasource/MockSourceBufferPrivate.h:
    (WebCore::MockSourceBufferPrivate::clearMediaSource):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  14. [Cocoa] Make WKWebProcessPlugInController work with WKObject wrapping

    weinig@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=125404
    
    Reviewed by Dan Bernstein.
    
    * Shared/Cocoa/APIObject.mm:
    (API::Object::newObject):
    * Shared/mac/ObjCObjectGraphCoders.mm:
    * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
    (-[WKWebProcessPlugInController dealloc]):
    (didCreatePage):
    (willDestroyPage):
    (-[WKWebProcessPlugInController _setPrincipalClassInstance:]):
    (-[WKWebProcessPlugInController API::]):
    * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:
    (WebKit::wrapper):
    * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h:
    * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
    (WebKit::InjectedBundle::load):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  15. Remove statusWithDirection static function from RenderBlockLineLayout

    zoltan@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=125372
    
    Reviewed by Andreas Kling.
    
    I run into a FIXME about using BidiStatus constructor rather than statusWithDirection,
    once it's implemented. BidiStatus has got the appropriate constructor now, so I removed
    statusWithDirection and updated the code to use the constructor of BidiStatus.
    
    No new tests, no behavior change.
    
    * rendering/RenderBlockLineLayout.cpp:
    (WebCore::constructBidiRunsForSegment):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  16. [Cocoa] WebData has a generic wrapper

    mitz@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=125402
    
    Reviewed by Sam Weinig.
    
    Added WKNSData, an NSData subclass that confroms to WKObject and wraps a WebData.
    
    * Shared/Cocoa/APIObject.mm:
    (API::Object::newObject): Allocate a WKNSData if the API::Object is data.
    * Shared/Cocoa/WKNSData.h: Added.
    (WebKit::wrapper): Added. Returns a WebData’s wrapper as an NSData.
    * Shared/Cocoa/WKNSData.mm: Added.
    (-[WKNSData dealloc]): Calls the WebData destructor.
    (-[WKNSData length]): Added.
    (-[WKNSData bytes]): Added.
    (-[WKNSData copyWithZone:]): Retains self.
    (-[WKNSData _apiObject]): Returns the wrapped WebData.
    * WebKit2.xcodeproj/project.pbxproj: Added references to new files.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  17. [Cocoa] Make WKWebProcessPlugInBrowserContextController work with WKO…

    weinig@apple.com authored
    …bject wrapping
    
    
    https://bugs.webkit.org/show_bug.cgi?id=125403
    
    Reviewed by Dan Bernstein.
    
    * Shared/Cocoa/APIObject.mm:
    (API::Object::newObject):
    * Shared/mac/ObjCObjectGraphCoders.mm:
    (WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
    * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
    (didCreatePage):
    (willDestroyPage):
    (setUpBundleClient):
    (-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundle:]):
    * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
    (-[WKWebProcessPlugInBrowserContextController dealloc]):
    (-[WKWebProcessPlugInBrowserContextController mainFrameDocument]):
    (-[WKWebProcessPlugInBrowserContextController selectedRange]):
    (-[WKWebProcessPlugInBrowserContextController API::]):
    (-[WKWebProcessPlugInBrowserContextController _bundlePageRef]):
    (-[WKWebProcessPlugInBrowserContextController handle]):
    (+[WKWebProcessPlugInBrowserContextController lookUpBrowsingContextFromHandle:]):
    * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
    (WebKit::wrapper):
    * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:
    * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
    (WebKit::InjectedBundle::load):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  18. [Cocoa] Convert a few more parts of MiniBrowser over to the Objective…

    weinig@apple.com authored
    …-C API
    
    
    https://bugs.webkit.org/show_bug.cgi?id=125401
    
    Reviewed by Dan Bernstein.
    
    * MiniBrowser/mac/WK2BrowserWindowController.m:
    (-[WK2BrowserWindowController fetch:]):
    (-[WK2BrowserWindowController reload:]):
    (-[WK2BrowserWindowController goBack:]):
    (-[WK2BrowserWindowController goForward:]):
    (-[WK2BrowserWindowController validateUserInterfaceItem:]):
    (-[WK2BrowserWindowController currentZoomFactor]):
    (-[WK2BrowserWindowController setCurrentZoomFactor:]):
    (-[WK2BrowserWindowController zoomIn:]):
    (-[WK2BrowserWindowController zoomOut:]):
    (-[WK2BrowserWindowController canResetZoom]):
    (-[WK2BrowserWindowController resetZoom:]):
    (-[WK2BrowserWindowController toggleZoomMode:]):
    (-[WK2BrowserWindowController updateTextFieldFromURL:]):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  19. Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup

    weinig@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=125400
    
    Reviewed by Dan Bernstein.
    
    * MiniBrowser/mac/AppDelegate.h:
    * MiniBrowser/mac/AppDelegate.m:
    * MiniBrowser/mac/WK2BrowserWindowController.h:
    * MiniBrowser/mac/WK2BrowserWindowController.m:
    (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
    (-[WK2BrowserWindowController dealloc]):
    (createNewPage):
    (-[WK2BrowserWindowController awakeFromNib]):
    (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
    (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
    (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
    (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
    Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
    replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Commits on Dec 7, 2013
  1. [GTK] Run each gtest subtest separately instead of in one go

    gns@gnome.org authored
    https://bugs.webkit.org/show_bug.cgi?id=125386
    
    Reviewed by Martin Robinson.
    
    This is what other ports are doing (except they build each test as a separate binary)
    and will help with the timeouts we sometimes hit because it applies to the full test
    run.
    
    * Scripts/run-gtk-tests:
    (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
    (TestRunner._run_google_test): run a single subtest from a gtest binary.
    (TestRunner._run_google_test_suite): call the binary once per subtest.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. Unreviewed. Build fix for gtk port after r160260.

    changseok.oh@collabora.com authored
    * loader/cache/CachedImage.h: Add missing a header.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. [Win][64-bit] Hitting breakpoint assembler instruction in callToJavaS…

    commit-queue@webkit.org authored
    …cript.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=125382
    
    Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-07
    Reviewed by Michael Saboff.
    
    The WinCairo results from run-javascriptcore-tests are the same as the WinCairo 32-bits results, when removing these breakpoints.
    
    * jit/JITStubsMSVC64.asm: Remove breakpoint instructions.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. Move PrettyPatch related code to prettypatch.py

    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=124937
    
    Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-07
    Reviewed by Ryosuke Niwa.
    
    This code seems to have a better place here than in Port, since PrettyPatch already knows
    pretty_patch_path, and this also unifies the usage of PrettyPatch
    
    * Scripts/webkitpy/common/prettypatch.py:
    (PrettyPatch.__init__):
    (PrettyPatch.pretty_diff):
    (PrettyPatch):
    (PrettyPatch.pretty_patch_available):
    (PrettyPatch.check_pretty_patch):
    (PrettyPatch.pretty_patch_text):
    * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
    (TestResultWriter.create_text_diff_and_write_result):
    * Scripts/webkitpy/layout_tests/models/test_run_results.py:
    (summarize_results):
    * Scripts/webkitpy/port/base.py:
    (Port.__init__):
    (Port.wdiff_available):
    (Port.check_image_diff):
    (Port.wdiff_text):
    * Scripts/webkitpy/port/base_unittest.py:
    (PortTest.test_pretty_patch_os_error):
    (PortTest.test_pretty_patch_script_error):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  5. Fix API test expectation following 160220.

    gns@gnome.org authored
    Rubber-stamped by Martin Robinson.
    
    Source/WebKit/gtk:
    
    * tests/testatkroles.c:
    (finish_loading): rename variable documentFrame -> document.
    (test_webkit_atk_get_role_document_frame): check for ATK_ROLE_DOCUMENT_WEB instead of
    ATK_ROLE_DOCUMENT_FRAME.
    (test_webkit_atk_get_role_heading): rename variable documentFrame -> document.
    (test_webkit_atk_get_role_image): ditto.
    (test_webkit_atk_get_role_link): ditto.
    (test_webkit_atk_get_role_list_and_item): ditto.
    (test_webkit_atk_get_role_paragraph): ditto.
    (test_webkit_atk_get_role_section): ditto.
    (test_webkit_atk_get_role_table): ditto.
    (test_webkit_atk_get_role_separator): ditto.
    (test_webkit_atk_get_role_combobox): ditto.
    (test_webkit_atk_get_role_form): ditto.
    (test_webkit_atk_get_role_check_box): ditto.
    (test_webkit_atk_get_role_entry): ditto.
    (test_webkit_atk_get_role_label): ditto.
    (test_webkit_atk_get_role_listbox): ditto.
    (test_webkit_atk_get_role_password_text): ditto.
    (test_webkit_atk_get_role_push_button): ditto.
    (test_webkit_atk_get_role_radio_button): ditto.
    
    Source/WebKit2:
    
    * UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:
    (testAtspiBasicHierarchy): check for ATK_ROLE_DOCUMENT_WEB instead of ATK_ROLE_DOCUMENT_FRAME.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. ubuntu software center hits _XReadEvents() error

    gns@gnome.org authored
    https://bugs.webkit.org/show_bug.cgi?id=123480
    
    Reviewed by Martin Robinson.
    
    * platform/gtk/WidgetBackingStoreGtkX11.cpp:
    (WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11): clear the surface
    before freeing the associated pixmap.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. [Mac] MiniBrowser Debug builds are compiled with -Os

    mitz@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=125376
    
    Reviewed by Tim Horton.
    
    * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
    the Debug configuration at the project level.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  8. [mac] Keep around more decoded image data, since it's purgeable

    timothy_horton@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=125273
    <rdar://problem/13205438>
    
    Unreviewed patch to fix review comments...
    
    
    * platform/graphics/BitmapImage.h:
    Dan noticed that these return statements were improperly indented.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. Make insertText message asynchronous for iOS.

    enrica@apple.com authored
    Reviewed by Benjamin Poulain.
    
    * UIProcess/ios/WebPageProxyIOS.mm:
    (WebKit::WebPageProxy::insertText):
    * WebProcess/WebPage/WebPage.h:
    * WebProcess/WebPage/WebPage.messages.in:
    * WebProcess/WebPage/ios/WebPageIOS.mm:
    (WebKit::WebPage::insertText):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  10. [MSE][Mac] Disable AVFoundation when enabling the MockMediaPlayerMedi…

    jer.noble@apple.com authored
    …aSource.
    
    
    https://bugs.webkit.org/show_bug.cgi?id=125338
    
    Reviewed by Darin Adler.
    
    The MediaSource API has some assumptions which break if more than one installed
    media engine supports MediaSources at the same time. So when enabling the mock
    media source engine in DRT or WKTR, disable AVFoundation so that only the mock
    engine will support media source loading.
    
    * testing/Internals.cpp:
    (WebCore::Internals::initializeMockMediaSource):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  11. Use NeverDestroyed instead of DEFINE_STATIC_LOCAL

    antti@apple.com authored
    Reviewed by Anders Carlsson.
    
    * rendering/RenderText.cpp:
    (WebCore::originalTextMap):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Something went wrong with that request. Please try again.