Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 4, 2013
  1. Background doesn't fully repaint when body has margins.

    zalan@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=119033
    
    Reviewed by Simon Fraser.
    
    Ensure that background-color changes do not leave unpainted areas when
    body has margins.
    
    Both <body> and <html> background-color get propagated up to the viewport.
    If <body> has background-color attribute set, while <html> doesn't, the color is
    applied not only on the <body> but on both the <html> and the viewport. However,
    it's not enough to mark the RenderView dirty because with tiles backing on,
    there could be areas outside of the viewport that need repaint. By marking
    the RenderView's graphics layer dirty instead, we ensure that all the related
    tiles get marked dirty too and the new background color covers all areas.
    
    Manual test added. When forcing top-level composition on (even with embedded iframe to
    make sure we don't do paintsIntoWindow rendering), the test case execution changes so much,
    that the repaint rects don't reflect the functionality difference anymore.
    
    .:
    
    Reviewed by Simon Fraser.
    
    * ManualTests/compositing/background-color-change-on-body-with-margin.html: Added.
    
    Source/WebCore:
    
    * page/FrameView.cpp:
    (WebCore::FrameView::reset):
    (WebCore::FrameView::layout):
    * page/FrameView.h:
    (WebCore::FrameView::needsFullRepaint):
    * rendering/RenderBox.cpp:
    (WebCore::RenderBox::styleWillChange):
    * rendering/RenderObjectChildList.cpp:
    (WebCore::RenderObjectChildList::removeChildNode):
    * rendering/RenderView.cpp:
    (WebCore::RenderView::repaintRootContents):
    (WebCore::RenderView::repaintViewAndCompositedLayers):
    * rendering/RenderView.h:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Commits on Dec 12, 2012
  1. Pre-painting should not paint out-of-view fixed position elements

    wangxianzhu@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=104724
    
    Reviewed by James Robinson.
    
    .:
    
    New manual test.
    
    * ManualTests/compositing/fixed-position-out-of-view-scroll-prepaint.html: Added.
    
    Source/WebCore:
    
    Test: ManualTests/compositing/fixed-position-out-of-view-scroll-prepaint.html
    
    * rendering/RenderLayer.cpp:
    (WebCore::RenderLayer::paintLayer): Don't paint out-of-view fixed position elements.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Commits on May 29, 2012
  1. Incomplete repaint on twitter.com when replying to a tweet

    simon.fraser@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=87553
    
    Reviewed by Dean Jackson.
    
    Manual test that adds a transform to a layer, forcing that
    layer to gain backing store.
    
    * ManualTests/compositing/requires-backing-change.html: Added.
    
    Source/WebCore:
    
    Reviewed by Dean Jackson.
    
    Style changes can cause a compositing layer to change between
    requiring its own backing store or not, e.g. with the addition
    or removal of a transform.
    
    When that happens, we need to repaint the ancesetor layer that
    this layer was, or will be drawing into.
    
    Factored some code out of layerWillBeRemoved() to be able to
    also call it from setRequiresOwnBackingStore().
    
    New manual test, ManualTests/compositing/requires-backing-change.html.
    I was not able to get an automated pixel test to work.
    
    * rendering/RenderLayerBacking.cpp:
    (WebCore::RenderLayerBacking::setRequiresOwnBackingStore):
    * rendering/RenderLayerCompositor.cpp:
    (WebCore::RenderLayerCompositor::updateCompositingLayers): Remove trailing whitespace.
    (WebCore::RenderLayerCompositor::repaintInCompositedAncestor):
    (WebCore::RenderLayerCompositor::layerWillBeRemoved):
    * rendering/RenderLayerCompositor.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Commits on Nov 19, 2011
  1. Move manual-tests out of WebCore.

    abarth@webkit.org authored
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Something went wrong with that request. Please try again.