New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittests refactored (PRC) #4

Merged
merged 5 commits into from Jan 29, 2016

Conversation

Projects
None yet
2 participants
@mephinet
Contributor

mephinet commented Jan 24, 2016

This patchset refactors the unittest suite of Mail::DeliveryStatus::BounceParser by implementing a check_report function that takes a message file name and a list of expectations, which are then tested to hold. Furthermore, several unittest files have been merged, all in all reducing the LOC by about 40%, thereby hopefully simplifying future maintenance and additions.

@rjbs rjbs merged commit 854b438 into rjbs:master Jan 29, 2016

@rjbs

This comment has been minimized.

Show comment
Hide comment
@rjbs

rjbs Jan 29, 2016

Owner

Philipp, this is great! The code is much cleaner, and there's less of it, and the tests run faster because of it.

Also, well done catching that wrongly-quoted \L!

Really, thanks very much for this, it's a great improvement. You can solicit for changes to make to my modules any time. ;)

Owner

rjbs commented Jan 29, 2016

Philipp, this is great! The code is much cleaner, and there's less of it, and the tests run faster because of it.

Also, well done catching that wrongly-quoted \L!

Really, thanks very much for this, it's a great improvement. You can solicit for changes to make to my modules any time. ;)

@mephinet

This comment has been minimized.

Show comment
Hide comment
@mephinet

mephinet Feb 1, 2016

Contributor

I'm glad you like it, most appreciated!

Contributor

mephinet commented Feb 1, 2016

I'm glad you like it, most appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment