Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding custom (displayed) target for CPAN::Uploader (and user/pass prompts) #146

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

Getty commented Feb 10, 2013

Trivial change that just adds an attribute target on UploadToCPAN that allows to set a custom text displayed instead of PAUSE. This is a followup on the already added change to CPAN::Uploader (target option)

Contributor

dolmen commented Feb 11, 2013

Note that I have already a pull request pending on CPAN::Uploader: #144

Getty commented Feb 12, 2013

Thanks for the hint, actually if your patch comes through and mine doesnt, then UploadToDuckPAN will start breaking I think. Lets hope mine can go through together with yours so that i can adapt UploadToDuckPAN then.

Contributor

dolmen commented Feb 15, 2013

As I discussed about my patch with @rjbs before creating it, I expect it will be merged. So I suggest you rebase your work on mine.

Getty commented Feb 15, 2013

Aehm! How i actually do this? I fork your repository and take my changes over to that new fork? Or can i somehow do it directly? I just did rebase in the context of one repository, not with this fork situation.

Contributor

dolmen commented Feb 27, 2013

Here is how to do it:

git remote add upstream git://github.com/rjbs/dist-zilla.git
git fetch upstream pull/144/head:pr_144
git checkout master # Your master that is supposed to be this PR
git rebase pr_144    # Rebase your master on top of my PR #144
# resolve conflicts, the "git add" for each resolved file
git push -f origin master # will replace the commits in this PR with the rebased ones

Note that it would have been cleaner if you had done your commits on a branch instead of directly on master.

Owner

rjbs commented Jul 25, 2015

  • attribute should be called destination_name
  • should default to PAUSE, rather than use a predicate, unless I'm confused?
  • not sure I see why target is being passed to the Uploader

With those changes, would apply.

Contributor

karenetheridge commented Feb 12, 2016

Getty tells me this was for DDG and is therefore no longer needed.

Owner

rjbs commented Feb 13, 2016

@Getty Shall I close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment