Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Prune distmeta.t when META.yml doesn't exist #40

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

doherty commented Apr 17, 2011

This prunes the test file when META.yml doesn't exist in the dist. This makes it easier to include in pluginbundles, where you don't necessarily know whether the file will be there. A test to make sure the file is indeed pruned when appropriate has been added

Owner

rjbs commented Jun 2, 2011

I don't like this being a pruner. I think it would make more sense if the file just wasn't added. That's going to mean we need proper plugin ordering... I don't know, I just think this isn't the best way.

Contributor

doherty commented Jun 3, 2011

Sure, it would make more sense to simply not add the test - but I couldn't find a way to do that.

Contributor

doherty commented Sep 11, 2011

If there is a good way to avoid adding the test in the first place, I'd be happy to re-do this (and update the meta json test plugin as well).

Owner

rjbs commented Dec 13, 2011

I would make MetaTests have a "conditional" option. If true, it means the file will only be added if it seems likely to be needed. It can decide that at file-gathering time by scanning $zilla->plugins for a MetaYAML plugin.

Contributor

karenetheridge commented Mar 17, 2013

what is adding distmeta.t to begin with?

Contributor

karenetheridge commented Aug 2, 2013

@karenetheridge: distmeta.t is being added by [MetaTests]. silly cat.

@rjbs rjbs added the Needs Rework label Jul 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment