Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Additional configuration for "follow_symlinks" #55

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
  • enable additional configuration for "follow_symlinks" use case

    without "follow_skip" GatherDir may die when processing some
    file/dir for the second time

Please see http://search.cpan.org/~jesse/perl-5.14.1/lib/File/Find.pm#follow_skip for exact details.

- enable additional configuration for "follow_symlinks" use case
  without "follow_skip" GatherDir may fail when processing some
  file/dir for the second time
Owner

rjbs commented Dec 13, 2011

I'm a little worried about getting more tied to the behavior of File::Find::Rule, which I'd like to stop using.

Can you spell out what behaviors you need available, so I can make sure they're documented as such, rather than being closely tied to the options for FFR?

Thanks!

Ok. Symlinks can form cyclic structures. Seems for protection against the infinite loop, default behavior of FFR is to immediately die when it encounter the file it has already processed (it keeps all resolved file names in hash and counts the processing times).

However in my use case, symlinks can form "good" cycles (w/o infinite loops). Its just a crazy way of working with dependencies in development environment in NodeJS.

FFR also has an option to not die on cycles - and patch makes it accessible via plugin configuration.

Hope that makes sense.

Regards, Nickolay

Any updates on this feature?

Owner

rjbs commented Dec 23, 2011

I was just churning through pull requests when I
got your request for updates.

SamuraiJack: What I was hoping was that you could update the docs
for the options in question so that they are clear in their intent
without saying that pass through to FFR so that later when I
replace all our use of FFR, they still make sense and work. ;-)

- renamed "follow_skip" to "allowallow_symlink_cycles"
- not refer to FFR in documentation

@rjbs Did you know, that you can merge the pull request from the web interface on github? ;)

Hey, any updates? Don't want to maintain an own copy of "GatherDir".

Owner

rjbs commented Apr 12, 2012

I just went to merge this. Honestly! I even did some minor tweaking of commits messages and whitespace (now available at rjbs/symlinks) but I see there are no tests.

I want to be able to replace File::Find::Rule in the future, and without tests for this, I'm sure to break it. Give me some tests and I promise to merge it within a few days of the patch!

Ok, will do in few days, thanks!

Contributor

karenetheridge commented Mar 17, 2013

Where's this at now?

@rjbs rjbs added the Abandoned? label Jul 25, 2015

Owner

rjbs commented Apr 21, 2016

I am closing this on the assumption that it is abandoned.

@rjbs rjbs closed this Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment