bring in Pod::Checker warning about =over without =back

rjbs · Apr 12, 2013 · a8b5d9b · a8b5d9b
1 parent 462378d
commit a8b5d9b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 12 deletions.
diff --git a/lib/Pod/Simple/BlackBox.pm b/lib/Pod/Simple/BlackBox.pm
@@ -1518,6 +1518,11 @@ sub _closers_for_all_curr_open {
     if($copy[0] eq '=for') {
       $copy[0] = '=end';
     } elsif($copy[0] eq '=over') {
+      $self->whine(
+        $still_open->[1]{start_line} ,
+        "=over without closing =back"
+      );
+
       $copy[0] = '=back';
     } else {
       die "I don't know how to auto-close an open $copy[0] region";

diff --git a/t/html01.t b/t/html01.t
@@ -115,7 +115,7 @@ SUBCLASS: {
 ok(
     My::Pod::HTML->_out(
         sub{  $_[0]->bare_output(1)  },
-        "=pod\n\n=over\n\n=item Foo\n\n",
+        "=pod\n\n=over\n\n=item Foo\n\n=back\n",
     ),
     "\n<dl>\n<dt><a name=\"howdy\"\n>Foo</a></dt>\n</dl>\n",
 );

diff --git a/t/items.t b/t/items.t
@@ -189,18 +189,22 @@ ok( $x->_out( join "\n\n", '', '',
 $d = 11;
 print "# Now checking that document-end closes things right...\n";
 
-ok( $x->_out( join "\n\n", '', '', 
-  '=over',
-    '=item *',
-    'Stuff',
-    '=cut',
-    'Stuff',
+ok( $x->_out(
+  # We know there'd be a warning about implicit =back; disable it!
+  sub { $_[0]->no_whining(1); },
+  join( "\n\n", '', '',
     '=over',
-      '=item 1.',
-        '=over 19',
-        'Gleiven',
-        'Squim F<.thingrc>!',
-  '', ''
+      '=item *',
+      'Stuff',
+      '=cut',
+      'Stuff',
+      '=over',
+        '=item 1.',
+          '=over 19',
+          'Gleiven',
+          'Squim F<.thingrc>!',
+    '', '',
+  ),
   ), join '',
    '<Document>',
    '<over-bullet indent="4">',