Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

These tests had failures when run as root.

Permissions-based negative tests were incorrectly passing.
  • Loading branch information...
commit 73aa084d14a5befc1251f309ff32189a6d0aa1a8 1 parent 2669bab
Randy J. Ray authored
2  t/11_base64_fh.t
@@ -207,6 +207,8 @@ SKIP: {
207 207 # it doesn't have the concept of chmod...
208 208 skip 'Tests involving directory permissions skipped on Windows', 2
209 209 if ($^O eq 'MSWin32' || $^O eq 'cygwin');
  210 + skip 'Tests involving directory permissions skipped under root', 2
  211 + if ($< == 0);
210 212
211 213 my $baddir = File::Spec->catdir(File::Spec->tmpdir(), "baddir_$$");
212 214 if (! mkdir $baddir)
2  t/20_xml_parser.t
@@ -530,6 +530,8 @@ test_bad_xml($badstr, 'End-of-parse error');
530 530 SKIP: {
531 531 skip 'Tests involving directory permissions skipped on Windows', 1
532 532 if ($^O eq 'MSWin32' || $^O eq 'cygwin');
  533 + skip 'Tests involving directory permissions skipped under root', 1
  534 + if ($< == 0);
533 535
534 536 my $baddir = File::Spec->catdir(File::Spec->tmpdir(), "baddir_$$");
535 537 if (! mkdir $baddir)
2  t/21_xml_libxml.t
@@ -408,6 +408,8 @@ like($ret, qr/Unknown tag "structt"/, 'Correct error message');
408 408 SKIP: {
409 409 skip 'Tests involving directory permissions skipped on Windows', 1
410 410 if ($^O eq 'MSWin32' || $^O eq 'cygwin');
  411 + skip 'Tests involving directory permissions skipped under root', 1
  412 + if ($< == 0);
411 413
412 414 my $baddir = File::Spec->catdir(File::Spec->tmpdir(), "baddir_$$");
413 415 if (! mkdir $baddir)
4 t/40_server.t
@@ -133,6 +133,10 @@ SKIP: {
133 133 # Let's test that server creation properly fails if/when HTTP::Daemon fails.
134 134 # First find a port in use, preferably under 1024:
135 135 SKIP: {
  136 + if ($< == 0)
  137 + {
  138 + skip 'Negative port-based test unreliable when run as root', 2;
  139 + }
136 140 $port = find_port_in_use();
137 141 if ($port == -1)
138 142 {

0 comments on commit 73aa084

Please sign in to comment.
Something went wrong with that request. Please try again.