Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

These tests had failures when run as root.

Permissions-based negative tests were incorrectly passing.
  • Loading branch information...
commit 73aa084d14a5befc1251f309ff32189a6d0aa1a8 1 parent 2669bab
Randy J. Ray authored
2  t/11_base64_fh.t
View
@@ -207,6 +207,8 @@ SKIP: {
# it doesn't have the concept of chmod...
skip 'Tests involving directory permissions skipped on Windows', 2
if ($^O eq 'MSWin32' || $^O eq 'cygwin');
+ skip 'Tests involving directory permissions skipped under root', 2
+ if ($< == 0);
my $baddir = File::Spec->catdir(File::Spec->tmpdir(), "baddir_$$");
if (! mkdir $baddir)
2  t/20_xml_parser.t
View
@@ -530,6 +530,8 @@ test_bad_xml($badstr, 'End-of-parse error');
SKIP: {
skip 'Tests involving directory permissions skipped on Windows', 1
if ($^O eq 'MSWin32' || $^O eq 'cygwin');
+ skip 'Tests involving directory permissions skipped under root', 1
+ if ($< == 0);
my $baddir = File::Spec->catdir(File::Spec->tmpdir(), "baddir_$$");
if (! mkdir $baddir)
2  t/21_xml_libxml.t
View
@@ -408,6 +408,8 @@ like($ret, qr/Unknown tag "structt"/, 'Correct error message');
SKIP: {
skip 'Tests involving directory permissions skipped on Windows', 1
if ($^O eq 'MSWin32' || $^O eq 'cygwin');
+ skip 'Tests involving directory permissions skipped under root', 1
+ if ($< == 0);
my $baddir = File::Spec->catdir(File::Spec->tmpdir(), "baddir_$$");
if (! mkdir $baddir)
4 t/40_server.t
View
@@ -133,6 +133,10 @@ SKIP: {
# Let's test that server creation properly fails if/when HTTP::Daemon fails.
# First find a port in use, preferably under 1024:
SKIP: {
+ if ($< == 0)
+ {
+ skip 'Negative port-based test unreliable when run as root', 2;
+ }
$port = find_port_in_use();
if ($port == -1)
{
Please sign in to comment.
Something went wrong with that request. Please try again.