Implementation for lt$, lte$, gt$, gte$ rules (See #3) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s resolved (See rjrodger#3)
| } | ||
|
|
||
| function castToNumber( val ) { | ||
| if( _.isNumber(val) ) { |
There was a problem hiding this comment.
castToNumber is not neccessary - JavaScript gives "good" values for <,>,<=,>= for all types - so we can generalize to strings, etc pure Date objects also work just fine
There was a problem hiding this comment.
"bad habits" from strongly typed languages. I will remove this function and check the tests.
rjrodger
added a commit
that referenced
this pull request
Sep 18, 2012
Implementation for lt$, lte$, gt$, gte$ rules (See #3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal validation rules for are commented out because they need #1 to be implemented.