Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow insertion into array above / below existing items #1352

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@fsteger
Copy link
Contributor

fsteger commented Jul 10, 2019

Reasons for making this change

Add function that allows adding new items anywhere inside the array. New function is available on each array item as onAddIndexClick

#1073

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature
fsteger and others added 2 commits Jul 10, 2019
Sync
@epicfaace

This comment has been minimized.

Copy link
Member

epicfaace commented Jul 26, 2019

Looks good - thanks!

@epicfaace epicfaace merged commit c8c0249 into rjsf-team:master Jul 26, 2019
6 checks passed
6 checks passed
Header rules - trusting-agnesi-d3347d No header rules processed
Details
Pages changed - trusting-agnesi-d3347d 1 new file uploaded
Details
Redirect rules - trusting-agnesi-d3347d No redirect rules processed
Details
Mixed content - trusting-agnesi-d3347d No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/trusting-agnesi-d3347d/deploy-preview Deploy preview ready!
Details
@gilomen2

This comment has been minimized.

Copy link

gilomen2 commented Aug 9, 2019

@epicfaace do you know which release this is planned to be apart of and when that release might happen? this is a super useful feature.

@epicfaace

This comment has been minimized.

Copy link
Member

epicfaace commented Aug 11, 2019

@gilomen2 trying to get a release out soon; honestly just trying to find a fix for #1396 because if we release the code as-is, it will break some functionality.

@epicfaace epicfaace mentioned this pull request Oct 16, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.