Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial fix: Added FormContextType and extending the F generic from it #3220

Merged

Conversation

heath-freenome
Copy link
Contributor

Reasons for making this change

  • partial fix for Fix Typescript generics support in all themes in the beta #3072 by adding the new FormContextType and extending the F generic from it
  • Updated @rjsf/utils to add the new FormContextType and update all types and functions to extend the F generic from it
  • Updated @rjsf/core to update all uses of the F generic to extend FormContextType
  • Updated the documentation around F accordingly
    • Also fixed an issue where the <S notation in Markdown caused strike-through formatting by changing it to \<S
  • Updated the CHANGELOG.md accordingly

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

- partial fix for rjsf-team#3072 by adding the new `FormContextType` and extending the `F` generic from it
- Updated `@rjsf/utils` to add the new `FormContextType` and update all types and functions to extend the `F` generic from it
- Updated `@rjsf/core` to update all uses of the `F` generic to extend `FormContextType`
- Updated the documentation around `F` accordingly
  - Also fixed an issue where the `<S` notation in Markdown caused strike-through formatting by changing it to `\<S`
- Updated the `CHANGELOG.md` accordingly
@heath-freenome heath-freenome merged commit c78a1c9 into rjsf-team:main Oct 31, 2022
5 checks passed
@heath-freenome heath-freenome deleted the fix-add-FormContextType branch October 31, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants