From cf972bfef04a784be2d314ed54d4ea99d90b2999 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Poul=20Kjeldager=20S=C3=B8rensen?= Date: Tue, 17 Oct 2023 11:10:03 +0200 Subject: [PATCH 1/2] fix: the uischema options are on the options object, not options.props -- How can this even have been approved and merged together without anyone notice. Easily seen in playground also, just add ui:widget textarea and ui:rows to a field and nothing happens with fluentui theme --- packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx b/packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx index d0face4153..ca27726f1a 100644 --- a/packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx +++ b/packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx @@ -83,7 +83,7 @@ export default function BaseInputTemplate< const _onBlur = ({ target: { value } }: FocusEvent) => onBlur(id, value); const _onFocus = ({ target: { value } }: FocusEvent) => onFocus(id, value); - const uiProps = _pick((options.props as object) || {}, allowedProps); + const uiProps = _pick((options) || {}, allowedProps); return ( <> From 5aeb15ab3a21991edeb6bc665070808678c3beed Mon Sep 17 00:00:00 2001 From: Heath C <51679588+heath-freenome@users.noreply.github.com> Date: Wed, 15 Nov 2023 10:57:53 -0800 Subject: [PATCH 2/2] Update packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx - Reviewer feedback --- packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx b/packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx index 635a43fbb6..db0c092d43 100644 --- a/packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx +++ b/packages/fluent-ui/src/BaseInputTemplate/BaseInputTemplate.tsx @@ -83,7 +83,7 @@ export default function BaseInputTemplate< const _onBlur = ({ target: { value } }: FocusEvent) => onBlur(id, value); const _onFocus = ({ target: { value } }: FocusEvent) => onFocus(id, value); - const uiProps = _pick((options) || {}, allowedProps); + const uiProps = _pick(options || {}, allowedProps); return ( <>