New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up mutation-related modules and fix issue #87 #108

Merged
merged 13 commits into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@rjust
Owner

rjust commented Aug 9, 2017

@jose, can you please take a look at these changes and either comment or approve?

@rjust rjust requested a review from jose Aug 9, 2017

@@ -83,6 +84,7 @@ =head1 OPTIONS
pod2usage(1) unless defined $cmd_opts{p} and defined $cmd_opts{c} and defined $cmd_opts{o} and defined $cmd_opts{b};
# TODO: Unused parameter: PID

This comment has been minimized.

@jose

jose Aug 10, 2017

Collaborator

It seems safe to remove -p parameter. Should we?

@jose

jose Aug 10, 2017

Collaborator

It seems safe to remove -p parameter. Should we?

This comment has been minimized.

@rjust

rjust Aug 11, 2017

Owner

I kept it for backward-compatibility. Otherwise, it is safe to remove the parameter -- and we should do so for the next major release.

@rjust

rjust Aug 11, 2017

Owner

I kept it for backward-compatibility. Otherwise, it is safe to remove the parameter -- and we should do so for the next major release.

This comment has been minimized.

@jose

jose Aug 11, 2017

Collaborator

ok.

@jose

jose Aug 11, 2017

Collaborator

ok.

@jose

PR looks good to me. I've just added minor comments to it.

@rjust rjust merged commit fee5ddf into master Aug 14, 2017

@rjust rjust deleted the fix_mutant_caching branch Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment