New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis ci build script #132

Merged
merged 17 commits into from Dec 11, 2017

Conversation

Projects
None yet
2 participants
@tomecho
Collaborator

tomecho commented Dec 10, 2017

No description provided.

tomecho added some commits Dec 10, 2017

@tomecho tomecho changed the title from basic config, will need to handle dependencies latter to travis ci build script Dec 10, 2017

tomecho added some commits Dec 10, 2017

@tomecho

This comment has been minimized.

Show comment
Hide comment
@tomecho

tomecho Dec 11, 2017

Collaborator

seems like travis is doing the right thing but test_tutorial.sh doesnt pass, locally or on travis

Collaborator

tomecho commented Dec 11, 2017

seems like travis is doing the right thing but test_tutorial.sh doesnt pass, locally or on travis

@rjust

This comment has been minimized.

Show comment
Hide comment
@rjust

rjust Dec 11, 2017

Owner

@tomecho, the output looks like the Java version is 1.8+. I can reproduce the error locally when executing the test_tutorial script under Java 8 -- it works fine under Java 7.

Owner

rjust commented Dec 11, 2017

@tomecho, the output looks like the Java version is 1.8+. I can reproduce the error locally when executing the test_tutorial script under Java 8 -- it works fine under Java 7.

@tomecho

This comment has been minimized.

Show comment
Hide comment
@tomecho

tomecho Dec 11, 2017

Collaborator
Collaborator

tomecho commented Dec 11, 2017

@rjust

This comment has been minimized.

Show comment
Hide comment
@rjust

rjust Dec 11, 2017

Owner

I think you need to set the language to java -- otherwise, the jdk setting will be ignored.

Owner

rjust commented Dec 11, 2017

I think you need to set the language to java -- otherwise, the jdk setting will be ignored.

@tomecho

This comment has been minimized.

Show comment
Hide comment
@tomecho

tomecho Dec 11, 2017

Collaborator

image
It looks like it wasn't necessary.

Collaborator

tomecho commented Dec 11, 2017

image
It looks like it wasn't necessary.

@rjust rjust merged commit d23934a into master Dec 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rjust rjust deleted the travis_ci branch Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment