Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bug table in README to explain Java 7 -> Java 8 changes #300

Merged
merged 7 commits into from Mar 8, 2020

Conversation

@Greg4cr
Copy link
Collaborator

Greg4cr commented Mar 6, 2020

This is a minor documentation change to address questions like #299. It notes the valid bug IDs and deprecated bug IDs, along with a short explanation of why some bug IDs are no longer available.

@Greg4cr Greg4cr added the tutorial label Mar 6, 2020
@Greg4cr Greg4cr requested a review from rjust Mar 6, 2020
@Greg4cr Greg4cr self-assigned this Mar 6, 2020
@rjust

This comment has been minimized.

Copy link
Owner

rjust commented Mar 6, 2020

Can you please also update the script that outputs the table?

@Greg4cr

This comment has been minimized.

Copy link
Collaborator Author

Greg4cr commented Mar 6, 2020

@rjust - Thanks for informing me about that script. I've added it to this branch and updated it to match the style.

(Bonus - it revealed an error I made in creating the table in the first place)

@rjust

This comment has been minimized.

Copy link
Owner

rjust commented Mar 7, 2020

@Greg4cr, I made a few minor fixes (renamed the script to match the name in master, and right-align number of bugs).

There is still one issue in the script: for collections, it outputs:

Bug IDs in Use
1,25-28

Deprecated Bug IDs (\*)
1-24

The 1 in Bug IDs in Use is wrong. (I already fixed this in the README.)

@rjust rjust merged commit 9bcdcea into master Mar 8, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@rjust rjust deleted the java-8-table branch Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.