New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping v2.12a #269

Merged
merged 4 commits into from Sep 12, 2018

Conversation

Projects
None yet
1 participant
@ababic
Contributor

ababic commented Sep 12, 2018

  • Bump version
  • Cycle deprecation warnings
  • Remove functionality at the end of it's deprecation period
  • Document breaking changes in release notes
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 12, 2018

Codecov Report

Merging #269 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   98.41%   98.46%   +0.05%     
==========================================
  Files          85       82       -3     
  Lines        2708     2678      -30     
==========================================
- Hits         2665     2637      -28     
+ Misses         43       41       -2
Impacted Files Coverage Δ
wagtailmenus/conf/defaults.py 100% <ø> (ø) ⬆️
wagtailmenus/utils/deprecation.py 100% <100%> (ø) ⬆️
wagtailmenus/conf/settings.py 100% <100%> (ø) ⬆️
wagtailmenus/__init__.py 76.47% <100%> (ø) ⬆️
wagtailmenus/utils/version.py 100% <0%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef0f38...a200d71. Read the comment docs.

codecov bot commented Sep 12, 2018

Codecov Report

Merging #269 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   98.41%   98.46%   +0.05%     
==========================================
  Files          85       82       -3     
  Lines        2708     2678      -30     
==========================================
- Hits         2665     2637      -28     
+ Misses         43       41       -2
Impacted Files Coverage Δ
wagtailmenus/conf/defaults.py 100% <ø> (ø) ⬆️
wagtailmenus/utils/deprecation.py 100% <100%> (ø) ⬆️
wagtailmenus/conf/settings.py 100% <100%> (ø) ⬆️
wagtailmenus/__init__.py 76.47% <100%> (ø) ⬆️
wagtailmenus/utils/version.py 100% <0%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef0f38...a200d71. Read the comment docs.

@ababic ababic merged commit 0926e73 into rkhleics:master Sep 12, 2018

3 checks passed

codecov/patch 100% of diff hit (target 98.41%)
Details
codecov/project 98.46% (+0.05%) compared to 4ef0f38
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ababic ababic deleted the ababic:housekeeping/2.12a branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment