New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split menu object preparation and rendering into separate methods #276

Merged
merged 1 commit into from Sep 23, 2018

Conversation

Projects
None yet
1 participant
@ababic
Contributor

ababic commented Sep 23, 2018

Breaks responsibility for getting/creating an appropriate menu object and calling it's prepare_to_render() method out into a separate method: _get_render_prepared_object(). This will help with future planned developments, such as rendering menus as JSON instead of to a template.

Break responsibility for getting/creating an appropriate menu instanc…
…e and calling it's prepare_to_render() method out to a separate method: _get_render_prepared_object()
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 23, 2018

Codecov Report

Merging #276 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   98.52%   98.53%   +<.01%     
==========================================
  Files          82       82              
  Lines        2718     2728      +10     
==========================================
+ Hits         2678     2688      +10     
  Misses         40       40
Impacted Files Coverage Δ
wagtailmenus/models/menus.py 97.39% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10a072...f87bf0c. Read the comment docs.

codecov bot commented Sep 23, 2018

Codecov Report

Merging #276 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   98.52%   98.53%   +<.01%     
==========================================
  Files          82       82              
  Lines        2718     2728      +10     
==========================================
+ Hits         2678     2688      +10     
  Misses         40       40
Impacted Files Coverage Δ
wagtailmenus/models/menus.py 97.39% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10a072...f87bf0c. Read the comment docs.

@ababic ababic merged commit 2d05937 into rkhleics:master Sep 23, 2018

3 checks passed

codecov/patch 100% of diff hit (target 98.52%)
Details
codecov/project 98.53% (+<.01%) compared to d10a072
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ababic ababic deleted the ababic:separate-preparation-and-rendering branch Sep 23, 2018

@ababic ababic referenced this pull request Sep 27, 2018

Open

Menus API #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment