New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPANTS Kwalitee issues #1

Merged
merged 3 commits into from Feb 26, 2018

Conversation

Projects
None yet
3 participants
@zakame
Copy link
Contributor

zakame commented Jan 23, 2018

This PR is a submission for my CPAN Pull Request Challenge this month.

This implements fixes for extra Kwalitee issues:

  • Declare minimum Perl version
  • Declare modules provided by this dist

zakame added some commits Jan 23, 2018

Add MinimumPerl plugin to dist.ini
Declare the minimum Perl version that this dist will run on.
Add MetaProvides::Package to dist.ini
Declare what modules this dist provides.
@rkitover

This comment has been minimized.

Copy link
Owner

rkitover commented Feb 26, 2018

Oh oops I completely missed this one, I'll merge it now.

@rkitover rkitover merged commit a157a3b into rkitover:master Feb 26, 2018

rkitover added a commit that referenced this pull request Feb 26, 2018

release #1
Release with CPANTS Kwalitee fixes from zakame.
@rkitover

This comment has been minimized.

Copy link
Owner

rkitover commented Feb 26, 2018

Released 0.20 with your fixes, thank you!

@zakame zakame deleted the zakame:fixes/kwalitee branch Feb 26, 2018

@zakame

This comment has been minimized.

Copy link
Contributor

zakame commented Feb 26, 2018

Thanks! 🎉

@rkitover

This comment has been minimized.

Copy link
Owner

rkitover commented Feb 26, 2018

I'm going to try to update @avar with these two modules as well.

Sorry, didn't mean to ping you, I meant the dzil plugin 🤦‍♂️

@avar

This comment has been minimized.

Copy link

avar commented Feb 26, 2018

@rkitover A lot of people have tried and failed to update me with proper English pluralization rules, good luck.

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment