Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inflection of proper nouns ending in -ity/-ities #2

Merged
merged 3 commits into from Jan 31, 2018

Conversation

@zakame
Copy link
Contributor

@zakame zakame commented Jan 29, 2018

This PR is another submission for my CPAN Pull Request Challenge this month.

This implements a fix for RT#118767 to correctly inflect proper nouns like "Functionality".

zakame added 3 commits Jan 22, 2018
Proper nouns seem to bypass the actual noun inflection functions, so try
to fix that here by including their NNP tag.
Probably needs a little more tweaking.
@rkitover
Copy link
Owner

@rkitover rkitover commented Jan 30, 2018

Hi, will take a look at this later today, sorry I've not been doing much perl stuff lately but I'll work with you on this.

@rkitover rkitover merged commit 18ac3ee into rkitover:master Jan 31, 2018
rkitover added a commit that referenced this issue Jan 31, 2018
Add zakame to contributors, update copyright years to 2018, remove
ancient SUPPORT POD block.
@rkitover
Copy link
Owner

@rkitover rkitover commented Jan 31, 2018

Uploaded 0.19 with your changes, thanks!

Don't know how many years it's been since I've uploaded anything to cpan.

@zakame
Copy link
Contributor Author

@zakame zakame commented Feb 1, 2018

Thanks a lot! :D Welcome back to CPAN 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants