From facc07619d8a7f25db14ff24a15b3fa51d97bda7 Mon Sep 17 00:00:00 2001 From: Luca Bruno Date: Wed, 22 May 2019 11:20:52 +0000 Subject: [PATCH] test: disable flaking tests on semaphore Tests that use aci-server can flake due to a global resource (localhost port 443). This disables them on SemaphoreCI. --- tests/rkt_fetch_test.go | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tests/rkt_fetch_test.go b/tests/rkt_fetch_test.go index 72b677b711..fc92cc9091 100644 --- a/tests/rkt_fetch_test.go +++ b/tests/rkt_fetch_test.go @@ -239,6 +239,11 @@ func testFetchUpdate(t *testing.T, args string, image string, imageArgs string, } func TestFetchNoStoreCacheControl(t *testing.T) { + // Flake: https://github.com/rkt/rkt/issues/3995 + if os.Getenv("SEMAPHORE") == "true" { + t.Skip("skipped on semaphore") + } + imageName := "rkt-inspect-fetch-nostore-cachecontrol" imageFileName := fmt.Sprintf("%s.aci", imageName) // no spaces between words, because of an actool limitation @@ -504,6 +509,11 @@ func testSimpleServerHandler(t *testing.T, imagePath string) http.HandlerFunc { } func TestDeferredSignatureDownload(t *testing.T) { + // Flake: https://github.com/rkt/rkt/issues/3995 + if os.Getenv("SEMAPHORE") == "true" { + t.Skip("skipped on semaphore") + } + imageName := "localhost/rkt-inspect-deferred-signature-download" imageFileName := fmt.Sprintf("%s.aci", filepath.Base(imageName)) // no spaces between words, because of an actool limitation @@ -552,6 +562,11 @@ func TestDeferredSignatureDownload(t *testing.T) { } func TestDifferentDiscoveryLabels(t *testing.T) { + // Flake: https://github.com/rkt/rkt/issues/3995 + if os.Getenv("SEMAPHORE") == "true" { + t.Skip("skipped on semaphore") + } + const imageName = "localhost/rkt-test-different-discovery-labels-image" aci_os, aci_arch := common.GetOSArch()