New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for empty volume types #1502

Merged
merged 4 commits into from Oct 1, 2015

Conversation

Projects
None yet
4 participants
@iaguis
Member

iaguis commented Sep 29, 2015

Fixes #1040

Show outdated Hide outdated stage1/init/pod.go
Show outdated Hide outdated stage1/init/pod.go
Show outdated Hide outdated common/common.go
@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Sep 29, 2015

Contributor

Seems pretty reasonable overall

Contributor

jonboulle commented Sep 29, 2015

Seems pretty reasonable overall

@iaguis

This comment has been minimized.

Show comment
Hide comment
@iaguis

iaguis Sep 30, 2015

Member

Updated

Member

iaguis commented Sep 30, 2015

Updated

Show outdated Hide outdated stage1/init/pod.go
Show outdated Hide outdated stage1/init/pod.go
@iaguis

This comment has been minimized.

Show comment
Hide comment
@iaguis

iaguis Sep 30, 2015

Member

I also modified the ACE functional test to use an empty volume like @jonboulle suggested in appc/spec#113 (comment)

Member

iaguis commented Sep 30, 2015

I also modified the ACE functional test to use an empty volume like @jonboulle suggested in appc/spec#113 (comment)

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Oct 1, 2015

Contributor

👍 thank you , looks great!

Contributor

jonboulle commented Oct 1, 2015

👍 thank you , looks great!

jonboulle added a commit that referenced this pull request Oct 1, 2015

Merge pull request #1502 from iaguis/empty-volume
Add support for empty volume types

@jonboulle jonboulle merged commit 85681e2 into rkt:master Oct 1, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment