New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage1: make root own files/dirs in stage1.aci #1503

Merged
merged 1 commit into from Oct 6, 2015

Conversation

Projects
None yet
5 participants
@iaguis
Member

iaguis commented Sep 29, 2015

Without this, the generated stage1 will have the uid and gid of the user
building it.

Fixes #1453

@alban

This comment has been minimized.

Show comment
Hide comment
@alban

alban Sep 29, 2015

Member

LGTM (after the changes in appc/spec and appc/goaci)

Member

alban commented Sep 29, 2015

LGTM (after the changes in appc/spec and appc/goaci)

@jellonek

This comment has been minimized.

Show comment
Hide comment
@jellonek

jellonek Sep 29, 2015

Contributor

LGTM

Contributor

jellonek commented Sep 29, 2015

LGTM

@alban

This comment has been minimized.

Show comment
Hide comment
@alban

alban Sep 30, 2015

Member

appc/spec#498 was merged. We are waiting for an appc/spec release now.

Member

alban commented Sep 30, 2015

appc/spec#498 was merged. We are waiting for an appc/spec release now.

@yifan-gu

This comment has been minimized.

Show comment
Hide comment
@yifan-gu

yifan-gu Oct 6, 2015

Contributor

So I guess a release on spec is the only blocker for this and #1452? /cc @jonboulle

Contributor

yifan-gu commented Oct 6, 2015

So I guess a release on spec is the only blocker for this and #1452? /cc @jonboulle

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Oct 6, 2015

Contributor

Yes, working on it

On Mon, Oct 5, 2015 at 5:40 PM, Yifan Gu notifications@github.com wrote:

So I guess a release on spec is the only blocker for this and #1452
#1452? /cc @jonboulle
https://github.com/jonboulle


Reply to this email directly or view it on GitHub
#1503 (comment).

Contributor

jonboulle commented Oct 6, 2015

Yes, working on it

On Mon, Oct 5, 2015 at 5:40 PM, Yifan Gu notifications@github.com wrote:

So I guess a release on spec is the only blocker for this and #1452
#1452? /cc @jonboulle
https://github.com/jonboulle


Reply to this email directly or view it on GitHub
#1503 (comment).

stage1: make root own files/dirs in stage1.aci
Without this, the generated stage1 will have the uid and gid of the user
building it.

iaguis added a commit that referenced this pull request Oct 6, 2015

Merge pull request #1503 from iaguis/stage1-root
stage1: make root own files/dirs in stage1.aci

@iaguis iaguis merged commit 1c0eb55 into rkt:master Oct 6, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment