New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage1: pass supplementary Gids to diagexec #1514

Merged
merged 2 commits into from Oct 6, 2015

Conversation

Projects
None yet
5 participants
@iaguis
Member

iaguis commented Sep 30, 2015

Fixes #1309

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Sep 30, 2015

Contributor

LGTM but please don't merge until we confirm in the spec.

Contributor

jonboulle commented Sep 30, 2015

LGTM but please don't merge until we confirm in the spec.

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Sep 30, 2015

Contributor

Oh actually, this is missing tests ;-)

Contributor

jonboulle commented Sep 30, 2015

Oh actually, this is missing tests ;-)

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle
Contributor

jonboulle commented Sep 30, 2015

@vcaputo

This comment has been minimized.

Show comment
Hide comment
@vcaputo

vcaputo Oct 1, 2015

Contributor

I added the necessary support to actool with an eye towards getting the functional tests working

Contributor

vcaputo commented Oct 1, 2015

I added the necessary support to actool with an eye towards getting the functional tests working

@iaguis

This comment has been minimized.

Show comment
Hide comment
@iaguis

iaguis Oct 1, 2015

Member

I added the necessary support to actool with an eye towards getting the functional tests working

Thanks! It's not in 0.7.0 so we need to wait for the next spec release.

Member

iaguis commented Oct 1, 2015

I added the necessary support to actool with an eye towards getting the functional tests working

Thanks! It's not in 0.7.0 so we need to wait for the next spec release.

@@ -97,6 +101,15 @@ func init() {
globalFlagset.IntVar(&globalFlags.ServeHttpTimeout, "serve-http-timeout", 30, "HTTP Timeout to wait for a client connection")
}
func in(list []int, el int) bool {

This comment has been minimized.

@krnowak

krnowak Oct 6, 2015

Collaborator

Wooo! Another implementation of in operator. I'll have to start adding some checks everytime I see it. :)

Disregard this comment. ;)

@krnowak

krnowak Oct 6, 2015

Collaborator

Wooo! Another implementation of in operator. I'll have to start adding some checks everytime I see it. :)

Disregard this comment. ;)

gids = append(gids, egid)
sort.Ints(gids)
}
var b bytes.Buffer

This comment has been minimized.

@krnowak

krnowak Oct 6, 2015

Collaborator

Or:

strGids := make([]string, len(gids))
for i, gid := range gids {
    strGids[i] = strconv.Itoa(gid)
}
fmt.Printf("Groups: %s\n", strings.Join(strGids, " ")

No need for bytes package.

Feel free to ignore it, anyway. :P

@krnowak

krnowak Oct 6, 2015

Collaborator

Or:

strGids := make([]string, len(gids))
for i, gid := range gids {
    strGids[i] = strconv.Itoa(gid)
}
fmt.Printf("Groups: %s\n", strings.Join(strGids, " ")

No need for bytes package.

Feel free to ignore it, anyway. :P

@krnowak

This comment has been minimized.

Show comment
Hide comment
@krnowak

krnowak Oct 6, 2015

Collaborator

LFAD.

Collaborator

krnowak commented Oct 6, 2015

LFAD.

iaguis added a commit that referenced this pull request Oct 6, 2015

Merge pull request #1514 from iaguis/supplemental-groups
stage1: pass supplementary Gids to diagexec

@iaguis iaguis merged commit 51cc14a into rkt:master Oct 6, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@pmorie

This comment has been minimized.

Show comment
Hide comment
@pmorie

pmorie Oct 6, 2015

Contributor

👏 awesome!

Contributor

pmorie commented Oct 6, 2015

👏 awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment