tests: add output when the test fails #1728

alban · 2015-11-11T11:29:45Z

--- FAIL: TestAPIServiceGetInfo (0.10s)
    rkt_api_service_test.go:37: Running rkt install
    rkt_api_service_test.go:42: Running rkt api service
    rkt_tests.go:125: rkt didn't terminate correctly: exit status 2

This patch should add more output.

/cc @yifan-gu

iaguis · 2015-11-11T13:45:20Z

tests/rkt_tests.go

@@ -111,11 +111,11 @@ func waitOrFail(t *testing.T, child *gexpect.ExpectSubprocess, shouldSucceed boo
 	err := child.Wait()
 	switch {
 	case !shouldSucceed && err == nil:
-		t.Fatalf("Expected test to fail but it didn't")
+		t.Fatalf("Expected test to fail but it didn't\nOutput:\n%s", child.Collect())


Collect() returns a []byte so you need to wrap it with a string().

Nevermind, %s will convert it automatically.

iaguis · 2015-11-11T13:55:49Z

If we've already Collected (for example, with an expect*WithOutput, the output would be empty right?

I guess it's good for cases where we don't expect (?)

alban · 2015-11-11T14:18:35Z

If we've already Collected (for example, with an expect*WithOutput, the output would be empty right?

expect*WithOutput only call Collect() in case of error, so the caller of expect*WithOutput should already print the output and exit in case of error.

iaguis · 2015-11-11T14:21:56Z

Fair enough. LGTM.

tests: add output when the test fails

tests: add output when the test fails

e848b37

alban mentioned this pull request Nov 11, 2015

tests: add functional tests for rkt api service. #1696

Closed

iaguis reviewed Nov 11, 2015
View reviewed changes

alban added a commit that referenced this pull request Nov 11, 2015

Merge pull request #1728 from alban/alban/test-output

a3f9e85

tests: add output when the test fails

alban merged commit a3f9e85 into rkt:master Nov 11, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: add output when the test fails #1728

tests: add output when the test fails #1728

alban commented Nov 11, 2015

iaguis Nov 11, 2015

iaguis Nov 11, 2015

iaguis commented Nov 11, 2015

alban commented Nov 11, 2015

iaguis commented Nov 11, 2015

tests: add output when the test fails #1728

tests: add output when the test fails #1728

Conversation

alban commented Nov 11, 2015

iaguis Nov 11, 2015

Choose a reason for hiding this comment

iaguis Nov 11, 2015

Choose a reason for hiding this comment

iaguis commented Nov 11, 2015

alban commented Nov 11, 2015

iaguis commented Nov 11, 2015