New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cat-manifest cmd for pods #1744

Merged
merged 3 commits into from Nov 17, 2015

Conversation

Projects
None yet
2 participants
@blixtra
Collaborator

blixtra commented Nov 14, 2015

We've had a cat-manifest for the ImageManifest but not for the PodManifest. This adds that missing functionality.

There is also a bit of related refactoring included.

Should close issue #1730

Show outdated Hide outdated rkt/pods.go Outdated
@blixtra

This comment has been minimized.

Show comment
Hide comment
@blixtra

blixtra Nov 16, 2015

Collaborator

Added tests and made @iaguis suggested change.

Collaborator

blixtra commented Nov 16, 2015

Added tests and made @iaguis suggested change.

@iaguis

This comment has been minimized.

Show comment
Hide comment
@iaguis

iaguis Nov 16, 2015

Member

Tests fail :(

Member

iaguis commented Nov 16, 2015

Tests fail :(

Show outdated Hide outdated rkt/enter.go Outdated
Show outdated Hide outdated rkt/run_prepared.go Outdated
Show outdated Hide outdated rkt/status.go Outdated
Show outdated Hide outdated tests/rkt_cat_manifest_test.go Outdated

blixtra added some commits Nov 14, 2015

rkt: implement cat-manifest for pods
We've had a cat-manifest for the ImageManifest but not for the
PodManifest. This adds that missing functionality.

Also added functional tests which required moving the previously wrongly
named TestCatManifest to TestImageCatManifest.

fixes #1730
@iaguis

This comment has been minimized.

Show comment
Hide comment
@iaguis

iaguis Nov 17, 2015

Member

LGTM

Member

iaguis commented Nov 17, 2015

LGTM

iaguis added a commit that referenced this pull request Nov 17, 2015

@iaguis iaguis merged commit 2b2c9cb into rkt:master Nov 17, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment