New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add functional tests for rkt api service. #1761

Merged
merged 2 commits into from Nov 19, 2015

Conversation

Projects
None yet
3 participants
@yifan-gu
Contributor

yifan-gu commented Nov 17, 2015

Add tests for GetInfo(), ListPods(), InspectPod()
ListImages() and InspectImage().

Fix #1668

This follows #1696 as semaphore refuses to test that branch :(

@yifan-gu

This comment has been minimized.

Show comment
Hide comment
@yifan-gu

yifan-gu Nov 17, 2015

Contributor

cc @alban @iaguis
The error doesn't appear now...

Contributor

yifan-gu commented Nov 17, 2015

cc @alban @iaguis
The error doesn't appear now...

@yifan-gu

This comment has been minimized.

Show comment
Hide comment
@yifan-gu

yifan-gu Nov 18, 2015

Contributor

Update: Have run the previously failing test (TestAPIServiceGetInfo) for 1000 times on my machine, no failures so far.
Trying to run 100000 times see if I can catch it. If not, maybe merge this for now until we have more info to understand what causes the previous error?

Contributor

yifan-gu commented Nov 18, 2015

Update: Have run the previously failing test (TestAPIServiceGetInfo) for 1000 times on my machine, no failures so far.
Trying to run 100000 times see if I can catch it. If not, maybe merge this for now until we have more info to understand what causes the previous error?

Show outdated Hide outdated tests/rkt_tests.go
@alban

This comment has been minimized.

Show comment
Hide comment
@alban

alban Nov 18, 2015

Member

LGTM after a rebase!

The TODO about #1730 can be done after this PR gets merged.

Member

alban commented Nov 18, 2015

LGTM after a rebase!

The TODO about #1730 can be done after this PR gets merged.

@yifan-gu

This comment has been minimized.

Show comment
Hide comment
@yifan-gu

yifan-gu Nov 18, 2015

Contributor

Actually among 16008 tests I run yesterday, there are 44 failures. It's seems reproduceable, still investigating.

Contributor

yifan-gu commented Nov 18, 2015

Actually among 16008 tests I run yesterday, there are 44 failures. It's seems reproduceable, still investigating.

@jonboulle

This comment has been minimized.

Show comment
Hide comment
@jonboulle

jonboulle Nov 18, 2015

Contributor

What are the failures?

Contributor

jonboulle commented Nov 18, 2015

What are the failures?

@yifan-gu

This comment has been minimized.

Show comment
Hide comment
@yifan-gu

yifan-gu Nov 18, 2015

Contributor

What are the failures?

I have no idea so far, the process just exits with status = 2

Contributor

yifan-gu commented Nov 18, 2015

What are the failures?

I have no idea so far, the process just exits with status = 2

@yifan-gu

This comment has been minimized.

Show comment
Hide comment
@yifan-gu

yifan-gu Nov 18, 2015

Contributor

I think I found out the reason, there is a race between the api service setting up the signal hander and the test sending the SIGINT.
There is a chance the test sends the SIGINT before the api-service setting up the signal handler, so the api service return with status = 2.

Contributor

yifan-gu commented Nov 18, 2015

I think I found out the reason, there is a race between the api service setting up the signal hander and the test sending the SIGINT.
There is a chance the test sends the SIGINT before the api-service setting up the signal handler, so the api service return with status = 2.

@yifan-gu

This comment has been minimized.

Show comment
Hide comment
@yifan-gu

yifan-gu Nov 19, 2015

Contributor

Also fixed the TODO for #1730

Contributor

yifan-gu commented Nov 19, 2015

Also fixed the TODO for #1730

tests: add functional tests for rkt api service.
Add tests for GetInfo(), ListPods(), InspectPod()
ListImages() and InspectImage().
@alban

This comment has been minimized.

Show comment
Hide comment
@alban

alban Nov 19, 2015

Member

Well spotted, LGTM.

Member

alban commented Nov 19, 2015

Well spotted, LGTM.

alban added a commit that referenced this pull request Nov 19, 2015

Merge pull request #1761 from yifan-gu/api_func_test
tests: add functional tests for rkt api service.

@alban alban merged commit 99aba43 into rkt:master Nov 19, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details

@yifan-gu yifan-gu deleted the yifan-gu:api_func_test branch Nov 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment